Bug #9307

about:addons is broken in Tor Browser 4.5 when Torbutton not installed

Added by anonym 2015-04-30 09:56:11 . Updated 2015-07-03 03:41:16 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_1.4.1
Start date:
2015-04-30
Due date:
% Done:

100%

Feature Branch:
Type of work:
Wait
Blueprint:

Starter:
Affected tool:
Browser
Deliverable for:

Description

See Feature #9031#note-19. This affects the Unsafe Browser, and in particular our automated test suite, but we have workarounds, see Bug #9305, Bug #9306. Let’s at least ask the Tor Browser people if they have an idea what’s going on.

Subtasks

Related issues

Related to Tails - Feature #9031: Upgrade to Tor Browser 4.5 Resolved 2015-03-26

History

#1 Updated by intrigeri 2015-05-01 03:55:26

#2 Updated by intrigeri 2015-05-01 03:55:57

  • Subject changed from about:addons is broken in Tor Browser 4.5 when Torbutton installed to about:addons is broken in Tor Browser 4.5 when Torbutton not installed

#3 Updated by anonym 2015-05-02 06:50:21

If we fix this, we may want to consider reverting commit:eb3e901b15064291589899c17faaa77fe7e28968 that changed our test suite to use about:support instead (which is a bit more complex). That is, if Bug #9306’s test/9306-fix-unsafe-browser-addons-check branch gets merged.

#4 Updated by anonym 2015-05-27 15:45:57

  • Target version set to Tails_1.4.1
  • Type of work changed from Communicate to Wait

Fixed upstream: https://trac.torproject.org/projects/tor/ticket/15984

> If we fix this, we may want to consider reverting eb3e901b15064291589899c17faaa77fe7e28968 that changed our test suite to use about:support instead (which is a bit more complex).

So let’s do this (to reduce the code complexity, and increase test suite robustness) once a suitable Tor Browser build is available.

#5 Updated by anonym 2015-07-01 11:51:26

  • Status changed from Confirmed to Fix committed
  • Assignee deleted (anonym)
  • % Done changed from 0 to 100

anonym wrote:
> Fixed upstream: https://trac.torproject.org/projects/tor/ticket/15984

I have confirmed it works in Tails 1.4.1 with Tor Browser 4.5.3. Closing.

> > If we fix this, we may want to consider reverting eb3e901b15064291589899c17faaa77fe7e28968 that changed our test suite to use about:support instead (which is a bit more complex).
>
> So let’s do this (to reduce the code complexity, and increase test suite robustness) once a suitable Tor Browser build is available.

This has been done in Feature #8548’s branch.

#6 Updated by intrigeri 2015-07-03 03:41:16

  • Status changed from Fix committed to Resolved