Bug #9258

Accessing systray icons in the test suite is fragile

Added by kytv 2015-04-18 00:27:05 . Updated 2015-05-12 18:37:33 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
Tails_1.4
Start date:
2015-04-18
Due date:
% Done:

100%

Feature Branch:
kytv:bugfix/9258-systray-is-ready
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

See Bug #8928#note-26 & Bug #8928#note-28

Subtasks

Related issues

Related to Tails - Feature #5632: Test suite: more robust encryption feature Resolved
Blocks Tails - Bug #9095: Seahorse tests lack robustness Resolved 2015-05-05

History

#1 Updated by kytv 2015-04-18 11:14:33

  • blocks Bug #9095: Seahorse tests lack robustness added

#2 Updated by kytv 2015-04-18 11:14:58

  • Status changed from New to In Progress

#3 Updated by kytv 2015-04-18 11:21:45

We want to wait until all of the systray icons have loaded before trying to interact with any of the icons in the systray. Otherwise, Sikuli may try clicking gpgApplet, for example, but if the systray is still being filled it could end up clicking something else entirely such as the notification icon or the volume control.

#4 Updated by kytv 2015-04-18 11:22:46

#5 Updated by kytv 2015-04-18 11:28:25

  • Subject changed from Accessing the gpgApplet in the test suite is fragile to Accessing systray icons in the test suite is fragile

Even though we currently only access gpgApplet all systray icon handling would be fragile.

#6 Updated by kytv 2015-04-18 11:36:07

  • related to Feature #5632: Test suite: more robust encryption feature added

#7 Updated by kytv 2015-04-18 17:43:19

  • Assignee changed from kytv to anonym
  • QA Check set to Ready for QA
  • Feature Branch set to kytv:bugfix/9258-systray-is-ready

#8 Updated by anonym 2015-05-05 19:10:58

  • Assignee changed from anonym to kytv
  • % Done changed from 0 to 20
  • QA Check changed from Ready for QA to Dev Needed

IMHO the correct place to put the code isn’t restore_background(). It’s conceivable that systray interaction is done before saving/restoring the background snapshot, and scenarios without any snapshot at all are already existing.

I think we should replace the GNOME has started step with with the Tails desktop is ready step, which does what GNOME has started does and what you added to restore_background(). And more things, later on, as we come up with them. So I wouldn’t mind a sed -i 's,GNOME has started,the Tails desktop is ready,g' $(git grep -l "GNOME has started").

#9 Updated by kytv 2015-05-05 22:58:16

  • Assignee changed from kytv to anonym
  • QA Check changed from Dev Needed to Ready for QA

Suggestions done, rewritten, and force pushed.

#10 Updated by kytv 2015-05-08 09:03:48

Applied in changeset commit:8aaaab820f3110f52c6dc5a556e9517ea741f1d7.

#11 Updated by anonym 2015-05-08 09:03:49

  • Status changed from In Progress to Fix committed
  • % Done changed from 20 to 100

Applied in changeset commit:4a77aed2678b20eb517e23e52af8b96963158617.

#12 Updated by anonym 2015-05-08 09:10:27

  • Assignee deleted (anonym)
  • QA Check changed from Ready for QA to Pass

#13 Updated by intrigeri 2015-05-08 10:57:03

Blocks: #8538

(Let’s see if that’s been fixed by some Redmine upgrade.)

#14 Updated by intrigeri 2015-05-09 15:41:33

  • blocks #8538 added

#15 Updated by BitingBird 2015-05-12 18:37:34

  • Status changed from Fix committed to Resolved