Bug #9189

The remote shell still hangs sometimes on Jessie hosts

Added by anonym 2015-04-08 08:26:57 . Updated 2015-05-12 18:38:55 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
Tails_1.4
Start date:
2015-04-08
Due date:
% Done:

100%

Feature Branch:
test/9189-allow-timeouts-in-try_for
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

That is after test/8165-run-test-suite-in-jessie (Feature #8165) was merged.

Subtasks

Related issues

Blocks Tails - Feature #9290: Allow nested try_for() Resolved 2015-04-29

History

#1 Updated by anonym 2015-04-08 08:28:33

  • Status changed from Confirmed to In Progress

Applied in changeset commit:ab91c97131cc178c3d821e332550ea3e2102228a.

#2 Updated by anonym 2015-04-08 08:29:28

  • Assignee changed from anonym to kytv
  • % Done changed from 0 to 50
  • Feature Branch set to test/9189-allow-timeouts-in-try_for

Please merge ASAP!

#3 Updated by intrigeri 2015-04-08 09:24:54

  • QA Check set to Ready for QA

#4 Updated by kytv 2015-04-12 18:45:49

Code looks good. Doing some test runs.

#5 Updated by kytv 2015-04-12 19:01:12

Minor problem: The variable name was changed in ceb9a1bc5c47e but the comment wasn’t updated.

diff --git a/features/support/helpers/misc_helpers.rb b/features/support/helpers/misc_helpers.rb
index 847cc0f..0d9e7a7 100644
--- a/features/support/helpers/misc_helpers.rb
+++ b/features/support/helpers/misc_helpers.rb
@@ -16,7 +16,7 @@ class TryForTimeoutError < Timeout::Error
 end

 # Call block (ignoring any exceptions it may throw) repeatedly with
-# one second breaks until it returns true, or until `t` seconds have
+# one second breaks until it returns true, or until `timeout` seconds have
 # passed when we throw a TryForTimeoutError exception. Nested try_for
 # is forbidden, so the block cannot itself call try_for.
 def try_for(timeout, options = {})

(Still running tests)

#6 Updated by kytv 2015-04-16 17:51:25

  • Assignee changed from kytv to anonym
  • QA Check changed from Ready for QA to Dev Needed

Testing (lots of testing) was successful. All I spotted was the comment which needs to be updated.

#7 Updated by intrigeri 2015-04-16 18:45:04

> Testing (lots of testing) was successful.

Woohoo! \o/

#8 Updated by anonym 2015-04-29 01:46:37

  • Assignee changed from anonym to intrigeri
  • QA Check changed from Dev Needed to Ready for QA

Typo fixed.

#9 Updated by anonym 2015-04-29 03:22:03

I recommend doing the review’n’merge of Feature #9290’s test/9290-nested-try_for branch (which is based on this ticket’s branch) at the same time as reviewing this.

#10 Updated by anonym 2015-04-29 04:02:40

#11 Updated by intrigeri 2015-04-29 04:06:41

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

Applied in changeset commit:0719d92011f8ac51ff2177ab9f7d0c5a53002b05.

#12 Updated by intrigeri 2015-04-29 04:07:10

Applied in changeset commit:e30e09d82f57ae2bef8d81c47a505099603751ca.

#13 Updated by intrigeri 2015-04-29 04:07:26

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

#14 Updated by BitingBird 2015-05-12 18:38:55

  • Status changed from Fix committed to Resolved