Feature #9171

Refactor tails-custom-apt-sources and tails-diff-suite duplicated code

Added by intrigeri 2015-04-07 15:15:04 . Updated 2015-04-07 15:43:58 .

Status:
Confirmed
Priority:
Normal
Assignee:
Category:
Build system
Target version:
Start date:
2015-04-07
Due date:
% Done:

0%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

After Feature #8654, we’ll have two implementations of e.g. branch_name_to_suite in two places. The logic of “what APT suite is used at build time for a given branch” is kinda duplicated too. Ideally, we should a single implementation, that both programs would use. It’s not trivial since they’re run in very different contexts. I see two main options:

  1. Have tails-diff-suites to load and run that shared code from the Git repository it’s using to find out the base branch etc. — it’s ugly but doable, and then the question is: from which branch?
  2. Put the shared implementation elsewhere. We could e.g. put it into our upcoming pythonlib or the existing perl5lib, but in both cases this adds a dependency to the ISO build system. Something like Feature #7036 could help manage such build-dependencies, by the way.

Both seem a bit too heavy to integrate into the already pretty radical Feature #8654, so I’m saving it for later.


Subtasks


Related issues

Related to Tails - Feature #7036: Move custom software to our main Git repository In Progress

History

#1 Updated by intrigeri 2015-04-07 15:15:17

  • related to Feature #7036: Move custom software to our main Git repository added

#2 Updated by intrigeri 2015-04-07 15:43:58

  • Description updated