Feature #9070

Kill test suite's virt-viewer properly

Added by anonym 2015-03-18 09:02:28 . Updated 2015-03-23 01:59:21 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
Tails_1.3.1
Start date:
2015-03-18
Due date:
% Done:

100%

Feature Branch:
test/9070-kill-virt-viewer-properly
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

From features/support/helpers/display_helper.rb:

  def start_virtviewer(domain)
    # virt-viewer forks, so we cannot (easily) get the child pid
    # and use it in active? and stop_virtviewer below...
    IO.popen(["virt-viewer", "-d",
                             "-f",
                             "-r",
                             "-c", "qemu:///system",
                             ["--display=", @x_display].join(''),
                             domain,
                             "&"].join(' '))


But actually, virt-viewer isn’t forking…. notice the & in the command. Gah!

Subtasks

History

#1 Updated by Tails 2015-03-18 09:49:51

  • Status changed from Confirmed to In Progress

Applied in changeset commit:eb9ea20748ec0b64e513830eece3eb26eba03f90.

#2 Updated by anonym 2015-03-18 09:51:12

  • Assignee deleted (anonym)
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA
  • Feature Branch set to test/9070-kill-virt-viewer-properly

#3 Updated by anonym 2015-03-18 16:35:24

  • Assignee set to kytv

The key thing to test is just that virt-viewer stops and starts properly between scenarios and features.

#4 Updated by kytv 2015-03-21 17:59:03

  • Assignee deleted (kytv)
  • QA Check changed from Ready for QA to Pass

The code looks sensible.

Without this branch I see errors like (virt-viewer:10851): Gdk-WARNING **: virt-viewer: Fatal IO error 11 (Resource temporarily unavailable) on X server :0. With this branch merged I do not, therefore I think it’s doing the right thing.

#5 Updated by intrigeri 2015-03-21 18:02:02

  • Assignee set to intrigeri

#6 Updated by intrigeri 2015-03-22 11:46:55

  • Target version changed from Tails_1.3.2 to Tails_1.3.1

#7 Updated by intrigeri 2015-03-22 12:29:14

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

Applied in changeset commit:d74940c637a9fdae91f5935a7e6ef5c4c5579cea.

#8 Updated by intrigeri 2015-03-22 12:30:28

  • Assignee deleted (intrigeri)

#9 Updated by BitingBird 2015-03-23 01:59:21

  • Status changed from Fix committed to Resolved