Feature #9069
Add menu entry to gpgApplet to open gedit directly
100%
Description
It would be great if the gpgApplet have an menu entry to open a texteditor (gedit or whatever) directly. Instead of choosing it in the application menu.
Files
Subtasks
History
#1 Updated by BitingBird 2015-03-17 18:24:05
- Affected tool set to OpenPGP Applet
#2 Updated by IvanBliminse 2015-03-17 19:16:40
- File addmenuentry.patch added
#3 Updated by sajolida 2015-03-18 13:02:28
- Status changed from New to Confirmed
- Assignee set to anonym
- % Done changed from 0 to 20
- QA Check set to Ready for QA
- Type of work changed from Code to Discuss
I’m not against that, especially now that we have a patch.
The label should be “Open Text Editor”.
Marking this as “Code” and assigning to anonym who is the original author of this thing.
anonym, do you think we should do that?
#4 Updated by anonym 2015-03-18 16:26:11
- Assignee changed from anonym to nodens
- QA Check changed from Ready for QA to Info Needed
sajolida wrote:
> I’m not against that, especially now that we have a patch.
>
> The label should be “Open Text Editor”.
>
> Marking this as “Code” and assigning to anonym who is the original author of this thing.
Actually, intrigeri started it, but I added the public key operation support. Nowadays I think nodens is our gpgApplet maintainer (although I may be wrong, please tell me in that case), so I’m reassigning for input. What do you think, nodens?
> anonym, do you think we should do that?
Well, it seems a bit bloaty to me. OTOH, if it helps educating users to write their plaintext in Gedit rather than some leak-prone web form, I suppose that’s a good thing. I’m not sure, though.
Also, from the patch:
+ my $mtext = Gtk2::MenuItem->new_with_mnemonic($encoding->decode(gettext('_Open Texteditor')));This should be:
+ my $mtext = Gtk2::MenuItem->new_with_mnemonic($encoding->decode(gettext('_Open Text Editor')));#5 Updated by nodens 2015-03-18 18:37:12
Hi,
I’m not against it either.
The patch should be updated to launch gnome-text-editor rather than gedit directly, though.
Also, this patch applies against the version currently in Tails but not the master branch in my repository, since the i18n system has changed : https://git-tails.immerda.ch/nodens/openpgp-applet/
(easy enough to adapt).
I’ll be happy to do it but may not be able to do it before a week or two. Feel free to provide an updated patch against master in the above repository if you want it to happen faster ;)
Cheers,
#6 Updated by nodens 2015-03-18 18:39:28
- Type of work changed from Discuss to Code
#7 Updated by nodens 2015-03-18 18:40:59
- QA Check changed from Info Needed to Dev Needed
#8 Updated by IvanBliminse 2015-03-18 23:09:23
- File add_text_editor.patch added
#9 Updated by nodens 2015-03-19 10:11:00
- Status changed from Confirmed to In Progress
- Assignee deleted (
nodens) - % Done changed from 20 to 40
- QA Check changed from Dev Needed to Ready for QA
Looks good to me.
I created a topic branch on my repo, to use a slightly modified (gettext is not used anymore directly) : feature/9069-Add_menu_entry_open_text_editor (see previous comment for url).
The patch should apply cleanly on current Tails OpenPGP Applet version, if we want to add this to the devel branch (I don’t think my version will be in debian before next release).
Cheers !
#10 Updated by intrigeri 2015-03-19 11:13:21
- Target version set to Tails_1.4
#11 Updated by anonym 2015-04-15 11:14:12
Applied in changeset commit:9dac94be1366bf80ecbc25ae190f3266dc356c07.
#12 Updated by anonym 2015-04-15 11:14:13
- Status changed from In Progress to Fix committed
- % Done changed from 40 to 100
Applied in changeset commit:b8e4445864cbec3777879eb5a322be8662f32b5e.
#13 Updated by anonym 2015-04-15 11:30:36
- QA Check changed from Ready for QA to Pass
Merged! This will be part of Tails 1.4. Thanks for your patch, Ivan, and thanks for your input, nodens!
#14 Updated by BitingBird 2015-05-12 18:41:08
- Status changed from Fix committed to Resolved