Bug #9067

Tor Launcher is not killed properly in 60-tor-ready-notification.sh

Added by anonym 2015-03-17 09:45:50 . Updated 2015-03-23 01:59:22 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Tor configuration
Target version:
Tails_1.3.1
Start date:
2015-03-17
Due date:
% Done:

100%

Feature Branch:
bugfix/9067-fix-tor-launcher-killer
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Tor Launcher
Deliverable for:

Description

We start Tor Launcher with -app but pgrep/@pkill@ for --app, so it will never be killed. Also, Tor Launcher is started with firefox-unconfined nowadays (regression since we introduced AppArmor for the Tor Browser), so it’s doubly broken.

Also 60-tor-ready-notification.sh is a poor name since we do more stuff in that hook. 60-tor-ready.sh is better.

Subtasks

History

#1 Updated by Tails 2015-03-17 09:52:25

  • Status changed from Confirmed to In Progress

Applied in changeset commit:3d7b622fd089a6094402f11182f50ace596da46f.

#2 Updated by anonym 2015-03-17 09:56:09

  • % Done changed from 0 to 50
  • QA Check set to Ready for QA
  • Feature Branch set to https://labs.riseup.net/code/issues/9067

To test:

  • Boot without network and in bridge mode
  • Set a very incorrect time (10+ years or something)
  • Plug network, input bridges into Tor Launcher
  • Verify that Tor Launcher is killed once the “Tor is ready” notification is shown

If you are lazy, you can run the Clock way in the past in bridge mode scenario in time_syncing.feature and monitor it carefully (or capture a video).

#3 Updated by anonym 2015-03-19 13:32:42

  • Assignee changed from anonym to kytv

#4 Updated by anonym 2015-03-19 13:32:56

  • Assignee deleted (kytv)

#5 Updated by anonym 2015-03-19 13:35:02

  • Feature Branch changed from https://labs.riseup.net/code/issues/9067 to test/9070-kill-virt-viewer-properly

Yup! I was (and is, to some extent) confused when setting the fields for this ticket! :)

#6 Updated by intrigeri 2015-03-19 14:25:26

  • Assignee set to anonym
  • QA Check changed from Ready for QA to Dev Needed
  • Feature Branch changed from test/9070-kill-virt-viewer-properly to bugfix/9067-fix-tor-launcher-killer

Breaks the build according to Jenkins: xgettext: error while opening "./../tmp/pot/60-tor-ready-notification.sh.pot" for reading: No such file or directory.

#7 Updated by anonym 2015-03-19 14:49:59

  • Assignee deleted (anonym)
  • QA Check changed from Dev Needed to Ready for QA

intrigeri wrote:
> Breaks the build according to Jenkins: xgettext: error while opening "./../tmp/pot/60-tor-ready-notification.sh.pot" for reading: No such file or directory.

Fixed now.

#8 Updated by intrigeri 2015-03-19 18:37:29

  • Assignee set to intrigeri

#9 Updated by intrigeri 2015-03-19 20:13:46

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)
  • % Done changed from 50 to 100
  • QA Check changed from Ready for QA to Pass

#10 Updated by intrigeri 2015-03-19 20:15:55

Applied in changeset commit:d5cd8c1393e53132be37ae517f96810fb9c341d8.

#11 Updated by BitingBird 2015-03-22 11:54:21

  • Target version changed from Tails_1.3.2 to Tails_1.3.1

#12 Updated by BitingBird 2015-03-23 01:59:22

  • Status changed from Fix committed to Resolved