Bug #9034

tails-unblock-network calls undefined log function

Added by intrigeri 2015-03-07 20:53:44 . Updated 2015-05-12 18:41:21 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Spoof MAC
Target version:
Tails_1.4
Start date:
2015-03-07
Due date:
% Done:

100%

Feature Branch:
bugfix/9034-remove-useless-logging
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

If the blacklist couldn’t be removed, it tries to call log, which doesn’t exist in POSIX shell. Of course there are very little chances that this happens given we rm -f it just before, so I wonder if it’s worth making this script any more complex by sourcing the relevant library file — perhaps we could just drop the check.

Subtasks

History

#1 Updated by anonym 2015-04-29 10:20:44

  • Status changed from Confirmed to In Progress

Applied in changeset commit:db77e5b07dd66f4da4f63e90f9033b166a7c694e.

#2 Updated by anonym 2015-04-29 10:21:16

  • Assignee deleted (anonym)
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA
  • Feature Branch set to bugfix/9034-remove-useless-logging

#3 Updated by intrigeri 2015-05-01 10:07:12

  • Assignee set to intrigeri

#4 Updated by intrigeri 2015-05-01 10:39:30

  • % Done changed from 50 to 60

Passes code review.

#5 Updated by intrigeri 2015-05-01 11:47:08

  • Status changed from In Progress to Fix committed
  • % Done changed from 60 to 100

Applied in changeset commit:f4f6fa6f3e1d0f9a9305c0efb6e4284018263fa0.

#6 Updated by BitingBird 2015-05-01 11:50:12

  • QA Check changed from Ready for QA to Pass

#7 Updated by intrigeri 2015-05-01 11:53:26

  • Assignee deleted (intrigeri)

#8 Updated by BitingBird 2015-05-12 18:41:21

  • Status changed from Fix committed to Resolved