Feature #8963

Write tests for Electrum

Added by kytv 2015-02-26 21:58:21 . Updated 2015-05-12 18:43:28 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
Tails_1.4
Start date:
2015-02-26
Due date:
% Done:

100%

Feature Branch:
kytv:test/8963-electrum
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

Now that Electrum (Feature #6739) is in Tails, there should be tests written for it.

Subtasks

History

#1 Updated by intrigeri 2015-03-30 09:42:49

  • Target version changed from Tails_1.3.2 to Tails_1.4

Looks like this wasn’t done in time => postponing.

#2 Updated by intrigeri 2015-03-30 09:43:36

#3 Updated by kytv 2015-05-08 19:06:54

  • Assignee changed from kytv to anonym
  • QA Check set to Ready for QA
  • Feature Branch set to kytv:test/8963-electrum

Due to bitcoin’s nature I don’t think there’s very much that we can test, but maybe what I’ve done here is worthwhile.

#4 Updated by anonym 2015-05-10 20:16:31

  • Assignee changed from anonym to kytv
  • % Done changed from 0 to 30
  • QA Check changed from Ready for QA to Dev Needed

I think you should create actual steps instead of some these I see "XXX" after at most YY seconds instances (at least for ElectrumPreferencesButton.png and ElectrumStatus.png). Just from reading these scenarios, I’m not sure exactly what we’re testing.

Also, please merge testing and s/GNOME has started/the Tails desktop is ready/.

#5 Updated by kytv 2015-05-10 21:05:25

I’ve created individual steps and am testing that it still works.

#6 Updated by kytv 2015-05-10 21:20:34

  • Assignee changed from kytv to anonym
  • QA Check changed from Dev Needed to Ready for QA

#7 Updated by anonym 2015-05-11 05:32:46

  • Assignee changed from anonym to kytv
  • % Done changed from 30 to 60
  • QA Check changed from Ready for QA to Dev Needed

I missed this the first time around, but the @keep_volumes tag isn’t needed. It’s only needed when we want to preserve the storage volumes between scenarios, not between reboots within the same scenario.

The new commit 04f12c1 has a completely wrong commit message, and commit a9e2cf9’s commit message is a bit off. Please rewrite the history and fixup the commit messages for those commits (I’ve saved a local version of the branch to diff against), then I’ll merge!

#8 Updated by kytv 2015-05-11 11:37:06

  • Assignee changed from kytv to anonym
  • QA Check changed from Dev Needed to Ready for QA

Perhaps now it’s good. If what I’ve done isn’t acceptable I’ve also saved the original/pre-rewrite branch.

I’m also bumping a timeout that I hit when --capture was enabled.

#9 Updated by kytv 2015-05-11 13:12:36

Applied in changeset commit:1369d916a4d7e42a82c6d5cda83183d10c0696ab.

#10 Updated by anonym 2015-05-11 13:12:36

  • Status changed from In Progress to Fix committed
  • % Done changed from 60 to 100

Applied in changeset commit:b54363301625374b0711c6e874be5e6f970c4256.

#11 Updated by anonym 2015-05-11 13:13:47

  • Assignee deleted (anonym)
  • QA Check changed from Ready for QA to Pass

#12 Updated by BitingBird 2015-05-12 18:43:29

  • Status changed from Fix committed to Resolved

#13 Updated by intrigeri 2015-06-10 18:55:14

  • blocks #8538 added