Bug #8876

"the I2P router console is ready" step can break due to too small timeout

Added by intrigeri 2015-02-06 17:47:13 . Updated 2015-02-24 22:42:04 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Test suite
Target version:
Tails_1.3
Start date:
2015-02-06
Due date:
% Done:

100%

Feature Branch:
kytv:test/8876-bump-i2p-console-is-ready-timeout
Type of work:
Code
Blueprint:

Starter:
Affected tool:
I2P
Deliverable for:

Description

I’ve seen it fail on a slow Internet connection, while a few seconds later a notification told me that the router console was ready.

How about bumping the timeout a bit, e.g.:

--- a/features/step_definitions/i2p.rb
+++ b/features/step_definitions/i2p.rb
@@ -7,7 +7,7 @@ end

 Given /^the I2P router console is ready$/ do
   next if @skip_steps_while_restoring_background
-  try_for(60) do
+  try_for(120) do
     @vm.execute('. /usr/local/lib/tails-shell-library/i2p.sh; ' +
                 'i2p_router_console_is_ready').success?
   end

Subtasks

History

#1 Updated by intrigeri 2015-02-06 17:47:50

  • blocks #8538 added

#2 Updated by kytv 2015-02-10 21:41:26

  • Assignee changed from kytv to anonym
  • Target version changed from Tails_1.3.2 to Tails_1.3
  • QA Check set to Ready for QA
  • Feature Branch set to kytv:test/8876-bump-i2p-console-is-ready-timeout

The bump is absolutely acceptable to me. Done in my branch at test/8876-bump-i2p-console-is-ready-timeout

#3 Updated by kytv 2015-02-10 22:01:57

  • Target version changed from Tails_1.3 to Tails_1.3.2

#4 Updated by intrigeri 2015-02-11 10:04:46

  • Target version changed from Tails_1.3.2 to Tails_1.3

#5 Updated by anonym 2015-02-11 10:44:45

  • Status changed from Confirmed to Fix committed
  • Assignee deleted (anonym)
  • % Done changed from 0 to 100
  • QA Check changed from Ready for QA to Pass

#6 Updated by BitingBird 2015-02-24 22:42:04

  • Status changed from Fix committed to Resolved