Bug #8875
Make running applications from the GNOME menu more robust, again
100%
Description
test/8140-more-robust-apps-menu improved things, but one commit on that branch wasn’t merged. Let’s check if it’s working and merge it if yes.
Subtasks
History
#1 Updated by intrigeri 2015-02-06 09:23:49
- Parent task set to
Feature #8539
#2 Updated by intrigeri 2015-02-06 09:23:59
- related to
Bug #8140: Running applications via the GNOME menu is fragile added
#3 Updated by intrigeri 2015-02-06 17:48:07
- blocks #8538 added
#4 Updated by intrigeri 2015-02-07 12:57:52
- Feature Branch set to test/8875-more-robust-apps-menu
#5 Updated by intrigeri 2015-02-07 13:55:31
- Assignee changed from intrigeri to anonym
- % Done changed from 10 to 50
- QA Check set to Ready for QA
#6 Updated by kytv 2015-02-08 19:13:14
It may not completely resolve the problem but it should help, and certainly won’t hurt.
+1 on this change.
(Not sure if I can (=should) change the QA Check status so I’m leaving it alone.)
#7 Updated by kytv 2015-02-08 20:09:41
I’d like to see this added to the step below it too, e.g.
diff --git a/features/step_definitions/common_steps.rb b/features/step_definitions/common_steps.rb
index 0ec498c..19c82c1 100644
--- a/features/step_definitions/common_steps.rb
+++ b/features/step_definitions/common_steps.rb
@@ -685,6 +685,9 @@ Given /^I start "([^"]+)" via the GNOME "([^"]+)"\/"([^"]+)" applications menu$/
prefix = 'Gnome'
end
@screen.wait_and_click(prefix + "ApplicationsMenu.png", 10)
+ @screen.hide_cursor
+ # Wait for the menu to be displayed, by waiting for one of its last entries
+ @screen.wait("GnomeApplicationsTails.png", 40)
@screen.wait_and_hover(prefix + "Applications" + submenu + ".png", 20)
@screen.wait_and_hover(prefix + "Applications" + subsubmenu + ".png", 20)
@screen.wait_and_click(prefix + "Applications" + app + ".png", 20)Without these changes the tests in Feature #7821 were really fragile for me.
#8 Updated by intrigeri 2015-02-09 09:34:57
kytv wrote:
> I’d like to see this added to the step below it too, e.g.
Done in the branch, now testing. Should be safe enough a change => shouldn’t block the review’n’merge process IMO.
#9 Updated by anonym 2015-02-09 13:28:10
- Assignee changed from anonym to intrigeri
- QA Check changed from Ready for QA to Dev Needed
kytv wrote:
> + screen.wait(“GnomeApplicationsTails.png”, 40)@
This will break the “I start the Tor Browser” step when run in windows_camouflage.feature. You need to do the prefix stuff here too, and add an appropriate image for when the camouflage is enabled.
#10 Updated by intrigeri 2015-02-09 13:45:47
> This will break the “I start the Tor Browser” step when run in
> windows_camouflage.feature. You need to do the prefix stuff here too, and add an
> appropriate image for when the camouflage is enabled.
Good catch, will fix that today.
#11 Updated by intrigeri 2015-02-09 13:58:21
- Assignee changed from intrigeri to anonym
- QA Check changed from Dev Needed to Ready for QA
Fixed with commit:44cd921, please review’n’merge. Thanks again!
#12 Updated by anonym 2015-02-11 10:44:35
- Status changed from In Progress to Fix committed
- Assignee deleted (
anonym) - % Done changed from 50 to 100
- QA Check changed from Ready for QA to Pass
#13 Updated by intrigeri 2015-02-24 15:16:30
- related to
Bug #8928: "unclutter" can cause spurious errors with some configurations added
#14 Updated by BitingBird 2015-02-24 22:42:13
- Status changed from Fix committed to Resolved