Feature #8859

Get rid of the splash screen of Tails Installer

Added by sajolida 2015-02-04 22:13:09 . Updated 2017-09-28 18:48:44 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Installation
Target version:
Tails_3.2
Start date:
2015-02-04
Due date:
% Done:

100%

Feature Branch:
feature/8860-tails-installer-improvements installer:master,tails/stretch
Type of work:
Code
Blueprint:

https://tails.boum.org/blueprint/bootstrapping/installer#simplify

Starter:
Affected tool:
Installer
Deliverable for:

Description

This is a broader objective of simplification of the workflow in Tails Installer:

  • In the context of Tails, on the side “Use existing Live system ISO” it should have a button to clone exisiting Tails.
  • Outside of the context of Tails it doesn’t need that cloning button.

This implies to change some parts of the code in depth: the “clone” feature is currently implemented as a command-line option, and quite a few things are done differently depending on whether it’s set or not, e.g. in the LiveUSBDialog class constructor => they will now need to be done differently dynamically, after the UI has been set up and the
target device has been chosen.

Team: u, kurono, sajolida, tchou

Subtasks

Related issues

Blocks Tails - Feature #13424: Core work 2017Q3: User experience Resolved 2017-07-05
Blocks Tails - Bug #14650: Package new upstream version of tails-installer -> bpo Resolved 2017-09-13

History

#1 Updated by intrigeri 2015-02-04 22:21:06

The “splash screen” is liveusb-creator-launcher in our liveusb-creator Git repository. The bulk of the code lives in liveusb/launcher.py in the same repo.

#2 Updated by intrigeri 2015-03-01 22:01:22

  • Assignee set to sajolida
  • QA Check set to Info Needed

I don’t get why this is a subtask of Feature #8549, and hence transitively blocking #8538. Given:

  • this change (adding the button) wasn’t made yet in Tails Installer as we ship it in Tails
  • there’s no clear roadmap wrt. when this change will be done on the Tails side of things (no idea who’ll do it and when)

=> I don’t understand why we should adjust to this change in the next 5 months for inclusion in Debian.

In other words: I don’t understand why adding this button on the Tails side, only to then remove it on the Debian side, is a blocker for Feature #8549. Especially since the package will only be in testing and jessie-backports, so there’s plenty of time to update it again later to hide that button.. once it actually exists.

(Side note: we discovered Feature #8980 recently, that will already add lots of unexpected work before Feature #8549 can happen, so let’s please limit the additions we make to the bare minimum.)

#3 Updated by intrigeri 2015-03-01 22:06:28

  • Assignee deleted (sajolida)
  • QA Check deleted (Info Needed)

Seen the ML thread, I’ll reply there if I’m still surprised or in disagreement.

#4 Updated by intrigeri 2015-03-01 23:04:08

  • blocked by Feature #8860: Tails Installer should autodetect if Tails is installed on the destination device added

#5 Updated by sajolida 2015-03-03 16:01:50

  • Description updated
  • Assignee deleted ()
  • Parent task deleted (Feature #8549)

Right, backing up now.

#6 Updated by intrigeri 2015-03-03 18:15:50

  • blocks deleted (Feature #8860: Tails Installer should autodetect if Tails is installed on the destination device)

#7 Updated by intrigeri 2015-03-03 18:16:24

#8 Updated by intrigeri 2015-03-03 18:17:33

  • blocks Feature #8860: Tails Installer should autodetect if Tails is installed on the destination device added

#9 Updated by intrigeri 2015-03-03 18:17:49

  • blocked by deleted (Feature #8860: Tails Installer should autodetect if Tails is installed on the destination device)

#10 Updated by intrigeri 2015-03-03 18:18:01

  • blocked by Feature #8860: Tails Installer should autodetect if Tails is installed on the destination device added

#11 Updated by intrigeri 2015-03-03 18:25:25

  • blocks deleted (Feature #8860: Tails Installer should autodetect if Tails is installed on the destination device)

#12 Updated by intrigeri 2015-03-03 18:25:46

  • blocked by Feature #9006: Simplify the Tails Installer splash screen added

#13 Updated by intrigeri 2015-03-03 18:26:49

  • Description updated

#14 Updated by sajolida 2015-08-14 12:04:39

  • Description updated
  • Target version set to 2016

#15 Updated by kurono 2015-12-02 10:03:30

  • Assignee set to kurono

#16 Updated by sajolida 2016-05-10 08:57:28

  • Blueprint set to https://tails.boum.org/blueprint/bootstrapping/installer#simplify

#17 Updated by kurono 2016-05-18 15:36:54

  • Target version changed from 2016 to Tails_2.5
  • QA Check set to Ready for QA
  • Feature Branch set to kurono/feature/9005-Improve-tails-installer

#18 Updated by intrigeri 2016-08-02 09:31:55

  • Target version changed from Tails_2.5 to Tails_2.6

#19 Updated by anonym 2016-09-20 16:53:48

  • Target version changed from Tails_2.6 to Tails_2.7

#20 Updated by BitingBird 2016-10-16 04:46:31

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 50

kurono: if you want review from someone, you should unassign yourself :)

#21 Updated by kurono 2016-10-22 15:54:18

  • Assignee deleted (kurono)

#22 Updated by sajolida 2016-11-01 12:45:07

  • Assignee set to sajolida

#23 Updated by sajolida 2016-11-13 10:25:33

  • Target version deleted (Tails_2.7)

#24 Updated by sajolida 2016-12-28 21:22:19

  • Assignee changed from sajolida to kurono
  • QA Check changed from Ready for QA to Dev Needed

Review sent.

#25 Updated by kurono 2017-01-31 21:06:06

  • Assignee changed from kurono to sajolida
  • QA Check changed from Dev Needed to Ready for QA

#26 Updated by sajolida 2017-03-18 11:00:40

  • Assignee changed from sajolida to kurono
  • QA Check changed from Ready for QA to Dev Needed

Sent a review on https://mailman.boum.org/pipermail/tails-ux/2017-March/003361.html.

#27 Updated by sajolida 2017-03-18 11:03:02

  • blocks deleted (Feature #9006: Simplify the Tails Installer splash screen)

#28 Updated by kurono 2017-04-20 16:01:31

  • Assignee changed from kurono to sajolida
  • QA Check changed from Dev Needed to Ready for QA

#29 Updated by sajolida 2017-05-23 17:38:23

  • Assignee changed from sajolida to kurono
  • QA Check changed from Ready for QA to Dev Needed

I sent another review on https://mailman.boum.org/pipermail/tails-ux/2017-May/003374.html.

#30 Updated by kurono 2017-06-08 16:56:26

  • Assignee changed from kurono to sajolida
  • QA Check changed from Dev Needed to Ready for QA

#31 Updated by sajolida 2017-06-30 15:56:21

  • Assignee changed from sajolida to intrigeri
  • Feature Branch changed from kurono/feature/9005-Improve-tails-installer to feature/9005-Improve-tails-installer

All my concerns are solved now.

Reassigning to intrigeri for the final code review.

#32 Updated by intrigeri 2017-06-30 15:58:24

  • Assignee changed from intrigeri to anonym
  • Target version set to Tails_3.2

Reassigning to the RM for the next major release. If I am needed for something specific, just say the word (and tell me what that thing is).

#33 Updated by intrigeri 2017-06-30 15:59:56

  • Feature Branch changed from feature/9005-Improve-tails-installer to installer:feature/9005-Improve-tails-installer

Also, I think the test suite will need an update. anonym, that’s part of “Test suite maintenance”. I suggest you file a dedicated sibbling ticket for that (and I’ll happily review it).

#34 Updated by intrigeri 2017-06-30 16:00:32

sajolida: if the corresponding doc update isn’t tracked by a ticket yet, please create one and ensure it blocks this one.

#35 Updated by sajolida 2017-06-30 16:01:40

#36 Updated by sajolida 2017-07-05 19:07:39

#37 Updated by sajolida 2017-07-05 19:07:57

#38 Updated by intrigeri 2017-09-12 10:24:12

I suspect my work on Feature #12705 will be non-trivial to merge with the large amount of changes this one brings. The freeze is in two days and this branch hasn’t been reviewed yet, plus we’re missing the corresponding test suite and doc update. So if we have to choose, I say let’s take Feature #12705 (that I plan to complete either today or tomorrow by noon CEST), postpone this one and try harder to review this in a timely manner.

#39 Updated by Anonymous 2017-09-13 11:06:39

  • blocks Bug #14650: Package new upstream version of tails-installer -> bpo added

#40 Updated by anonym 2017-09-15 00:40:14

  • Assignee changed from anonym to kurono
  • % Done changed from 50 to 70
  • QA Check changed from Ready for QA to Dev Needed
  • Feature Branch changed from installer:feature/9005-Improve-tails-installer to tails:feature/12705-bump-system-partition-size installer:feature/9005-Improve-tails-installer

#41 Updated by anonym 2017-09-15 17:47:31

  • Feature Branch deleted (tails:feature/12705-bump-system-partition-size installer:feature/9005-Improve-tails-installer)

#42 Updated by anonym 2017-09-15 17:48:08

For the review, see: Feature #8860#note-38 and later comments.

#43 Updated by intrigeri 2017-09-18 17:32:03

  • Assignee changed from kurono to anonym
  • Priority changed from Normal to Elevated

(Same as Feature #8860.)

#44 Updated by anonym 2017-09-20 18:33:48

  • Assignee changed from anonym to intrigeri
  • QA Check changed from Dev Needed to Info Needed

See Feature #8860#note-49.

#45 Updated by anonym 2017-09-20 18:36:15

  • Feature Branch set to feature/8860-tails-installer-improvements installer:master,tails/stretch

For the review’n’merge: in an attempt to save some time, I prepared tails-installer 4.20 which I hope is good enough to ship in Tails 3.2 (unless we receive enough translations in the next couple of days, which would warrant another release).

#46 Updated by intrigeri 2017-09-21 10:39:31

  • Assignee changed from intrigeri to anonym
  • QA Check changed from Info Needed to Dev Needed

#47 Updated by anonym 2017-09-23 11:30:58

  • QA Check changed from Dev Needed to Ready for QA

#48 Updated by anonym 2017-09-25 16:49:20

  • Status changed from In Progress to Fix committed
  • Assignee deleted (anonym)
  • % Done changed from 70 to 100
  • QA Check changed from Ready for QA to Pass

#49 Updated by anonym 2017-09-28 18:48:44

  • Status changed from Fix committed to Resolved