Feature #8726

Use homogenous Debian mirrors at build time

Added by intrigeri 2015-01-19 00:54:06 . Updated 2015-02-24 22:43:15 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Build system
Target version:
Tails_1.3
Start date:
2015-01-19
Due date:
% Done:

100%

Feature Branch:
feature/8726-use-homogenous-Debian-mirrors-at-build-time
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

We’re currently hard-coding very little about the Debian mirrors we use at build time in our Git tree.

Historically, this was meant to allow people to choose their preferred mirror (e.g. local mirror) and to cope with squid-deb-proxy’s lack of flexibility. Nowadays, most of us use apt-cacher-ng, that can rewrite such URLs on the fly if needed (generally a bad idea, but oh well), so probably we don’t need this flexibility anymore.

Besides, this level of flexibility has just hit us hard, by introducing a bug (Bug #8715) that has taken many hours to 3 of us to debug. More generally, our stuff will be more consistent, easier to reproduce, and our QA process will be more reliable if we all use the same mirrors at build time as the one we configure in the ISO.

So, I plan to:

  • hard-code in auto/config all mirrors that shall be used at build time
  • update vagrant/provision/setup-tails-builder so that it doesn’t configure LB_MIRROR_BINARY nor LB_PARENT_MIRROR_BINARY, and deconfigures them if present
  • update tails::builder so that it doesn’t configure LB*MIRROR*, and deconfigures them if present
  • update wiki/src/contribute/build.mdwn so that it doesn’t advise to set $LB*MIRROR*
  • ask for comments about it to tails-dev@, before sending a pull request

Subtasks

Related issues

Related to Tails - Bug #8715: Cannot update APT package list without using torify Resolved 2015-01-16

History

#1 Updated by intrigeri 2015-01-19 00:54:15

  • related to Bug #8715: Cannot update APT package list without using torify added

#2 Updated by intrigeri 2015-01-19 00:56:46

  • Type of work changed from Code to Discuss

#3 Updated by intrigeri 2015-01-19 12:29:02

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 10
  • Feature Branch set to feature/8726-use-homogenous-Debian-mirrors-at-build-time
  • Tested with non-standard values in /etc/live/build.conf => they’re overriden by the mirrors defined in auto/config.
  • Tested with no /etc/live/build.conf at all => builds fine.

#4 Updated by intrigeri 2015-01-19 12:32:05

  • % Done changed from 10 to 20

Started the discussion on https://mailman.boum.org/pipermail/tails-dev/2015-January/007906.html

#5 Updated by intrigeri 2015-01-26 11:11:50

  • Type of work changed from Discuss to Code

No opposition on the ML. Next step is to have tails::builder stop configuring LB*MIRROR*, and deconfigures them if present.

#6 Updated by intrigeri 2015-01-26 11:26:58

  • Assignee deleted (intrigeri)
  • % Done changed from 20 to 50
  • QA Check set to Ready for QA

Ready for QA, lives in:

  • feature/8726-use-homogenous-Debian-mirrors-at-build-time in our main Git repo (anonym?)
  • feature/8726-use-homogenous-Debian-mirrors-at-build-time in our “tails” Puppet module (bertagaz)

The later shall not be deployed before the former is merged into all branches we build automatically.

#7 Updated by Tails 2015-01-26 13:47:18

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

Applied in changeset commit:73a4ec9a58dfb1f59306e86182abdeeb2e61eb7f.

#8 Updated by anonym 2015-01-26 13:57:07

  • QA Check deleted (Ready for QA)

#9 Updated by BitingBird 2015-01-26 14:58:42

  • QA Check set to Pass

#10 Updated by anonym 2015-01-26 19:21:54

  • Status changed from Fix committed to In Progress
  • Assignee set to bertagaz
  • % Done changed from 100 to 80
  • QA Check changed from Pass to Ready for QA

Apparently the puppet part remains for the “tails” module.

#11 Updated by bertagaz 2015-02-04 13:12:26

  • Status changed from In Progress to Fix committed
  • Assignee deleted (bertagaz)
  • % Done changed from 80 to 100
  • QA Check changed from Ready for QA to Pass

Merged and applied on lizard, the changes are deployed correctly. Congrats!

#12 Updated by BitingBird 2015-02-24 22:43:15

  • Status changed from Fix committed to Resolved