Feature #8695

Test if we can replace our Torbutton test_enabled patch with the TOR_SKIP_CONTROLPORTTEST environment variable

Added by intrigeri 2015-01-14 12:28:46 . Updated 2015-04-01 14:47:03 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_1.4
Start date:
2015-01-14
Due date:
% Done:

100%

Feature Branch:
Type of work:
Test
Blueprint:

Starter:
Affected tool:
Browser
Deliverable for:

Description

Our current patch is debian/patches/0002-Add-a-extensions.torbutton.test_enabled-boolean-pref.patch in our torbutton Git repo, and was proposed upstream on https://trac.torproject.org/projects/tor/ticket/10216.

Since then, a new TOR_SKIP_CONTROLPORTTEST environment variable was introduced, that might be able to replace our patch.

Subtasks

History

#1 Updated by BitingBird 2015-01-14 15:30:20

  • Category set to Tor configuration

#2 Updated by intrigeri 2015-01-14 16:00:14

  • Category deleted (Tor configuration)

#3 Updated by anonym 2015-03-31 19:33:47

  • Assignee set to anonym

#4 Updated by anonym 2015-04-01 13:24:09

  • Status changed from Confirmed to Resolved
  • Assignee deleted (anonym)
  • % Done changed from 0 to 100

I built feature/9031-tor-browser-4.5 with Tor Browser 4.5a5, which now installs the bundled Torbutton since upstream 1.9.1.0 includes 0002-Add-a-extensions.torbutton.test_enabled-boolean-pref.patch. Actually, it now seems we got two upstream solutions for this problem, because setting TOR_SKIP_CONTROLPORTTEST also works (and yes, I did disable extensions.torbutton.test_enabled when testing).

I tend to like it better when things are set via a pref rather than polluting the environment, i.e. I’m for the current status quo. Any way, the testing is done, so I’m closing this ticket, but if someone feels the TOR_SKIP_CONTROLPORTTEST solution is better, please open a new ticket and argue your case.

#5 Updated by intrigeri 2015-04-01 14:47:03

> Actually, it now seems we got two upstream solutions for this
> problem, because setting TOR_SKIP_CONTROLPORTTEST also works (and
> yes, I did disable extensions.torbutton.test_enabled when
> testing).

Wow, crazy timing, our stuff was merged only a few days ago.

> I tend to like it better when things are set via a pref rather than polluting the
> environment, i.e. I’m for the current status quo.

Works for me.