Bug #8680

Unable to clone Git repositories over HTTPS

Added by kytv 2015-01-12 13:44:07 . Updated 2015-02-24 22:45:08 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_1.3
Start date:
2015-01-12
Due date:
% Done:

100%

Feature Branch:
bugfix/8680-git-without-polipo
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

The tests created for Feature #8669 (not yet publicly available) do not pass in the devel branch. They do pass in stable. The command git clone https://github.com/tails-developers/testing-dummy</code> fails with a “cannot connect to host” error.

Subtasks

History

#1 Updated by intrigeri 2015-01-16 16:11:14

  • Subject changed from Unable to clone git repositories over HTTPS to Unable to clone Git repositories over HTTPS

#2 Updated by intrigeri 2015-01-16 16:19:26

So apparently, GIT_PROXY_COMMAND is taken into account for git:// and SSH connections, but not for HTTPS. Interesting. Looking into that further.

#3 Updated by Tails 2015-01-16 16:58:12

  • Status changed from Confirmed to In Progress

Applied in changeset commit:f736306c004e8bc5bbb1b29e599845da6555e35d.

#4 Updated by intrigeri 2015-01-16 16:59:22

  • Feature Branch set to bugfix/8680-git-without-polipo

#5 Updated by Tails 2015-01-16 19:24:15

Applied in changeset commit:c81d8d683844520c8e476cc9bc24418bd497391b.

#6 Updated by intrigeri 2015-01-16 19:27:24

  • Assignee deleted (intrigeri)
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA

#7 Updated by anonym 2015-01-26 14:10:20

We should test Git://, SSH and HTTP (s) both on the open Internet, and hidden services.

#8 Updated by intrigeri 2015-01-26 18:55:07

> We should test Git://, SSH and HTTP (s) both on the open Internet, and hidden services.

Right. (Note that as far as this ticket is concerned, we should only look for regressions compared to 1.2.3: any other problem will be for another ticket, and should not block merging this one.)

#9 Updated by bertagaz 2015-01-27 13:12:47

  • Assignee set to bertagaz

#10 Updated by bertagaz 2015-02-05 16:13:38

  • Assignee changed from bertagaz to intrigeri
  • QA Check changed from Ready for QA to Dev Needed

It looks good, except I think we’re doing the same mistake that lead to Bug #8603 and Bug #8830, regarding using `$*` rather than `$@` to pass arguments in the git wrapper (config/chroot_local-includes/usr/local/bin/git).

#11 Updated by intrigeri 2015-02-05 16:44:34

> It looks good, except I think we’re doing the same mistake that lead to Bug #8603 and
> Bug #8830, regarding using `$*` rather than `$@` to pass arguments in the git wrapper
> (config/chroot_local-includes/usr/local/bin/git).

You probably mean:

rather that "$@"

… and then indeed, you’re fully right. Fixed in the branch. I didn’t bother testing as it seems trivial enough and you’ll have to do a whole bunch of tests on it anyway.

#12 Updated by intrigeri 2015-02-05 16:45:20

  • Assignee changed from intrigeri to bertagaz
  • QA Check changed from Dev Needed to Ready for QA

#13 Updated by Tails 2015-02-05 18:16:45

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

Applied in changeset commit:1e240fbd5ed13d47b14a665f978df71eaa8b976a.

#14 Updated by bertagaz 2015-02-05 18:19:00

  • Assignee deleted (bertagaz)
  • QA Check changed from Ready for QA to Pass

Tested with last changes on devel (merge of Bug #8603 and Bug #8830), was able to clone with git,ssh,http andd htpps.

#15 Updated by BitingBird 2015-02-24 22:45:08

  • Status changed from Fix committed to Resolved