Feature #8670

Write tests for Git over SSH

Added by anonym 2015-01-10 17:34:26 . Updated 2015-02-24 22:46:50 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
Start date:
2015-01-10
Due date:
% Done:

100%

Feature Branch:
kytv:test/8670-git-over-ssh
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description


Subtasks


Related issues

Blocked by Tails - Bug #8644: Setup a Git repo for automated Git tests Resolved 2015-01-09
Blocked by Tails - Feature #8669: Write tests for anonymous Git Resolved 2015-01-10

History

#1 Updated by anonym 2015-01-10 17:34:42

  • blocked by Bug #8644: Setup a Git repo for automated Git tests added

#2 Updated by kytv 2015-01-15 18:16:38

  • Assignee changed from kytv to anonym
  • % Done changed from 0 to 40
  • QA Check set to Ready for QA
  • Feature Branch set to kytv:test/8670-git-over-ssh

#3 Updated by kytv 2015-01-15 18:21:09

  • Assignee deleted (anonym)

#4 Updated by intrigeri 2015-01-16 10:08:20

  • Assignee set to anonym

#5 Updated by kytv 2015-01-16 13:17:32

  • Status changed from Confirmed to In Progress

#6 Updated by intrigeri 2015-02-12 12:43:44

#7 Updated by intrigeri 2015-02-12 12:43:49

  • related to deleted (Feature #8669: Write tests for anonymous Git)

#8 Updated by intrigeri 2015-02-12 12:43:57

#9 Updated by intrigeri 2015-02-12 12:44:19

FTR, this branch is forked of the one for Feature #8669.

#10 Updated by intrigeri 2015-02-12 14:16:26

  • Assignee changed from anonym to kytv
  • QA Check changed from Ready for QA to Dev Needed
  • Feature Branch changed from kytv:test/8670-git-over-ssh to test/8670-git-over-ssh

I’ve pushed a bunch of improvements to test/8670-git-over-ssh. However, the added tests depend on the TAILS_TEST_SECRET_KEY envvar, and I see nowhere documented that one needs to define it, nor how => looks like something is still missing for that branch to be ready to be merged.

#11 Updated by anonym 2015-02-12 14:38:41

intrigeri wrote:
> I’ve pushed a bunch of improvements to test/8670-git-over-ssh. However, the added tests depend on the TAILS_TEST_SECRET_KEY envvar, and I see nowhere documented that one needs to define it, nor how => looks like something is still missing for that branch to be ready to be merged.

Indeed, but I think there’s been a misunderstanding here. Now the secret key can be stored in the clear in the Tails Git repo. The secret key is already stored in the clear for the world to see in the tails@git.tails.boum.org:myprivatekeyispublic/testing Git repo used in the “Cloning git repository over SSH” scenario added in this branch. So we can do:

--- a/features/step_definitions/git.rb
+++ b/features/step_definitions/git.rb
@@ -8,8 +8,36 @@ end
 Given /^I have the SSH key pair for a Git repository$/ do
   next if @skip_steps_while_restoring_background
   @vm.execute_successfully("install -m 0700 -d '/home/#{$live_user}/.ssh/'", $live_user)
-  secret_key=ENV['TAILS_TEST_SECRET_KEY']
-  public_key=ENV['TAILS_TEST_PUBLIC_KEY']
+  secret_key=<<EOF
+-----BEGIN RSA PRIVATE KEY-----
+MIIEowIBAAKCAQEAvMUNgUUM/kyuo26m+Xw7igG6zgGFMFbS3u8m5StGsJOn7zLi
+J8P5Mml/R+4tdOS6owVU4RaZTPsNZZK/ClYmOPhmNvJ04pVChk2DZ8AARg/TANj3
+qjKs3D+MeKbk1bt6EsA55kgGsTUky5Ti8cc2Wna25jqjagIiyM822PGG9mmI6/zL
+YR6QLUizNaciXrRM3Q4R4sQkEreVlHeonPEiGUs9zx0swCpLtPM5UIYte1PVHgkw
+ePsU6vM8UqVTK/VwtLLgLanXnsMFuzq7DTAXPq49+XSFNq4JlxbEF6+PQXZvYZ5N
+eW00Gq7NSpPP8uoHr6f1J+mMxxnM85jzYtRx+QIDAQABAoIBAA8Bs1MlhCTrP67q
+awfGYo1UGd+qq0XugREL/hGV4SbEdkNDzkrO/46MaHv1aVOzo0q2b8r9Gu7NvoDm
+q51Mv/kjdizEFZq1tvYqT1n+H4dyVpnopbe4E5nmy2oECokbQFchRPkTnMSVrvko
+OupxpdaHPX8MBlW1GcLRBlE00j/gfK1SXX5rcxkF5EHVND1b6iHddTPearDbU8yr
+wga1XO6WeohAYzqmGtMD0zk6lOk0LmnTNG6WvHiFTAc/0yTiKub6rNOIEMS/82+V
+l437H0hKcIN/7/mf6FpqRNPJTuhOVFf+L4G/ZQ8zHoMGVIbhuTiIPqZ/KMu3NaUF
+R634jckCgYEA+jJ31hom/d65LfxWPkmiSkNTEOTfjbfcgpfc7sS3enPsYnfnmn5L
+O3JJzAKShSVP8NVuPN5Mg5FGp9QLKrN3kV6QWQ3EnqeW748DXMU6zKGJQ5wo7ZVm
+w2DhJ/3PAuBTL/5X4mjPQL+dr86Aq2JBDC7LHJs40I8O7UbhnsdMxKcCgYEAwSXc
+3znAkAX8o2g37RiAl36HdONgxr2eaGK7OExp03pbKmoISw6bFbVpicBy6eTytn0A
+2PuFcBKJRfKrViHyiE8UfAJ31JbUaxpg4bFF6UEszN4CmgKS8fnwEe1aX0qSjvkE
+NQSuhN5AfykXY/1WVIaWuC500uB7Ow6M16RDyF8CgYEAqFTeNYlg5Hs+Acd9SukF
+rItBTuN92P5z+NUtyuNFQrjNuK5Nf68q9LL/Hag5ZiVldHZUddVmizpp3C6Y2MDo
+WEDUQ2Y0/D1rGoAQ1hDIb7bbAEcHblmPSzJaKirkZV4B+g9Yl7bGghypfggkn6o6
+c3TkKLnybrdhZpjC4a3bY48CgYBnWRYdD27c4Ycz/GDoaZLs/NQIFF5FGVL4cdPR
+pPl/IdpEEKZNWwxaik5lWedjBZFlWe+pKrRUqmZvWhCZruJyUzYXwM5Tnz0b7epm
++Q76Z1hMaoKj27q65UyymvkfQey3ucCpic7D45RJNjiA1R5rbfSZqqnx6BGoIPn1
+rLxkKwKBgDXiWeUKJCydj0NfHryGBkQvaDahDE3Yigcma63b8vMZPBrJSC4SGAHJ
+NWema+bArbaF0rKVJpwvpkZWGcr6qRn94Ts0kJAzR+VIVTOjB9sVwdxjadwWHRs5
+kKnpY0tnSF7hyVRwN7GOsNDJEaFjCW7k4+55D2ZNBy2iN3beW8CZ
+-----END RSA PRIVATE KEY-----
+EOF
+  public_key="ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQC8xQ2BRQz+TK6jbqb5fDuKAbrOAYUwVtLe7yblK0awk6fvMuInw/kyaX9H7i105LqjBVThFplM+w1lkr8KViY4+GY28nTilUKGTYNnwABGD9MA2PeqMqzcP4x4puTVu3oSwDnmSAaxNSTLlOLxxzZadrbmOqNqAiLIzzbY8Yb2aYjr/MthHpAtSLM1pyJetEzdDhHixCQSt5WUd6ic8SIZSz3PHSzAKku08zlQhi17U9UeCTB4+xTq8zxSpVMr9XC0suAtqdeewwW7OrsNMBc+rj35dIU2rgmXFsQXr49Bdm9hnk15bTQars1Kk8/y6gevp/Un6YzHGczzmPNi1HH5 amnesia@amnesia"
   assert(!secret_key.nil? && secret_key.length > 0)
   assert(!public_key.nil? && public_key.length > 0)
   @vm.execute_successfully("echo '#{secret_key}' > '/home/#{$live_user}/.ssh/id_rsa'", $live_user)

Or they can be put in features/support/config.rb. Once Feature #8188 is fixed we can store them in the mechanism added there. All still in the clear and we don’t care.

#12 Updated by kytv 2015-02-15 20:15:36

  • Target version changed from Tails_1.4 to Tails_1.3

#13 Updated by kytv 2015-02-15 23:51:55

  • Assignee changed from kytv to anonym
  • % Done changed from 40 to 50
  • QA Check changed from Dev Needed to Ready for QA
  • Feature Branch changed from test/8670-git-over-ssh to kytv:test/8670-git-over-ssh

#14 Updated by Tails 2015-02-17 17:21:46

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

Applied in changeset commit:ad31741f162e3cd93a0298e66faee1cca2a51066.

#15 Updated by anonym 2015-02-17 17:22:12

  • Assignee deleted (anonym)
  • QA Check changed from Ready for QA to Pass

Merged!

#16 Updated by BitingBird 2015-02-24 22:46:50

  • Status changed from Fix committed to Resolved