Feature #8437

Test whether we could use curl for all HTTP requests in check-mirrors

Added by sajolida 2014-12-14 18:22:17 . Updated 2018-04-21 15:51:43 .

Status:
Confirmed
Priority:
Low
Assignee:
Category:
Infrastructure
Target version:
Start date:
2014-12-14
Due date:
% Done:

0%

Feature Branch:
Type of work:
Test
Blueprint:

Starter:
1
Affected tool:
check-mirrors
Deliverable for:

Description

We currently rely on Ruby Net::HTTP, wget, and curl to do HTTP requests as part of check-mirrors. But as learned through Feature #8054, there is no SOCKS support for Ruby in Wheezy.

This could probably be simplify and rely only on curl, and possibly curl bindings for Ruby, to do all HTTP transactions. For example, ruby-curb or ruby-ethon are both in Jessie but not in Wheezy.

Source code: git clone https://git.tails.boum.org/check-mirrors
Mentoring: tails-mirrors@boum.org

Subtasks

Related issues

Related to Tails - Bug #11152: Have SSL on our rsync communications with mirrors Confirmed 2016-02-21

History

#1 Updated by intrigeri 2014-12-22 09:05:52

#2 Updated by BitingBird 2015-01-04 18:51:52

  • Category changed from 214 to Infrastructure
  • Affected tool set to check-mirrors

#3 Updated by Anonymous 2018-01-19 15:19:56

  • related to Bug #11152: Have SSL on our rsync communications with mirrors added

#4 Updated by Anonymous 2018-01-19 15:23:35

  • Assignee set to sajolida
  • QA Check set to Info Needed

I have the slight feeling that this ticket is outdated.
It tries to resolve some old situation in which there was no SOCKS support in Ruby.

However, check-mirrors.rb now has this support:


 68 def wget(mirror, uri, *argv)
 69   uri = uri.to_s
 70   uri.gsub!(BASE_URL.to_s, "http://#{mirror}/tails/") if is_ip(mirror)
 71   args = argv.join(' ')
 72   default_args = ['--server-response', '--tries=2'].join(' ')
 73   if OPTIONS.torify
 74     status, output = execute('torsocks', 'wget', '--no-proxy', default_args, uri, args)

So i’m tempted to reject this ticket but i’m unsure if i missed something?

#5 Updated by sajolida 2018-04-21 15:29:03

  • Assignee deleted (sajolida)
  • Priority changed from Normal to Low
  • Parent task deleted (Feature #8054)
  • QA Check deleted (Info Needed)

I’m not sure this is still relevant after Feature #8054#note-34. I’ll leave this up to whoever will want to work on check-mirrors in the future.

#6 Updated by sajolida 2018-04-21 15:49:46

  • Description updated
  • Starter set to Yes

#7 Updated by sajolida 2018-04-21 15:51:43

  • Description updated