Feature #8358

Automatically check PO files in all our repositories

Added by intrigeri 2014-12-02 06:49:47 . Updated 2019-03-08 15:54:27 .

Status:
Rejected
Priority:
Low
Assignee:
Category:
Continuous Integration
Target version:
Start date:
2014-12-02
Due date:
% Done:

0%

Feature Branch:
Type of work:
Sysadmin
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

This could be done in a number of ways:

  • on our Jenkins, which was the initial plan, that’s still expressed in the ticket relationships; pros: we already have most of the building blocks in place; cons: only very few people can do this work and the way test results are published is not user friendly at all for people who don’t have access to the Jenkins interface and need to navigate https://nightly.tails.boum.org/check_PO_master/
  • via Bug #15362; pros: some people are actively working in this area; cons: AFAIK that’s not a complete CI system that already knows how to send notifications, publish test results and their history on the web, this sort of things, and I’d rather not see us reinvent that wheel
  • with GitLab CI, e.g. on Salsa or 0xacab; pros: super simple to set up, test results & history are published nicely for everyone, more of us know how to manage that compared to Jenkins; cons: I’m slightly concerned about the confusion that can be caused by adding another CI platform to our toolboxJenkins does

Subtasks

Related issues

Related to Tails - Bug #15362: Pre-commit hook/Run check_po whenever we try to commit a po file in all Git repositories Resolved 2018-03-02
Related to Tails - Bug #15186: Evaluate moving to GitLab for merge requests Resolved 2018-08-30

History

#1 Updated by intrigeri 2014-12-02 06:50:03

  • blocked by Feature #8357: Turn the check_PO Jenkins job into a template added

#2 Updated by intrigeri 2015-06-12 20:04:05

Looks like wiki/src/contribute/l10n_tricks/check_po.sh will need to be moved from the main Git repo to another one, then. Perhaps it’s time to introduce a dedicated repo for such tools needed on Jenkins slaves, and add it as a submodule in the main Git repo? Note that this script works as-is (modulo the language selection via command-line argument, but we don’t need that here) in any tree that contains *.po files.

#3 Updated by intrigeri 2015-06-12 20:51:57

  • Status changed from Confirmed to In Progress

jenkins-tools repo created, copied the current check_po script there. Next step is to replace it with a symlink to a new submodule in the main Git repo, will track this with a subtask.

#4 Updated by intrigeri 2017-06-05 14:26:23

  • Assignee deleted (intrigeri)

Would be nice to have (it would save a few minutes during each release process) but no reason I should do it.

#5 Updated by Anonymous 2017-06-28 08:09:56

  • Assignee set to bertagaz

Tentatively assigning to bertagaz. Please unassign yourself if you think you can’t work on this.
This might be a ticket for new team mates otherwise.

#6 Updated by intrigeri 2017-06-28 08:49:25

  • Assignee deleted (bertagaz)
  • Priority changed from Normal to Low

I think bertagaz should focus on stuff we have explicitly put on our plate for this year.

#7 Updated by Anonymous 2018-08-18 12:53:36

  • related to Bug #15362: Pre-commit hook/Run check_po whenever we try to commit a po file in all Git repositories added

#8 Updated by Anonymous 2018-08-18 12:54:41

  • Assignee set to intrigeri
  • QA Check set to Info Needed

Do we agree that this already happened: “jenkins-tools repo created, copied the current check_po script there. Next step is to replace it with a symlink to a new submodule in the main Git repo”?

#9 Updated by Anonymous 2018-08-18 12:55:21

Our work on the translation platform might actually solve this issue, see Bug #15362.

#10 Updated by intrigeri 2018-08-18 14:37:32

> Do we agree that this already happened: “jenkins-tools repo created, copied the current check_po script there. Next step is to replace it with a symlink to a new submodule in the main Git repo”?

Yes.

#11 Updated by intrigeri 2018-08-18 14:37:58

> Our work on the translation platform might actually solve this issue, see Bug #15362.

OK, I’ll reply there. Thanks!

#12 Updated by intrigeri 2018-08-18 14:39:34

  • Assignee deleted (intrigeri)
  • QA Check deleted (Info Needed)

#13 Updated by intrigeri 2018-08-19 07:51:58

  • Description updated

#14 Updated by intrigeri 2018-08-19 07:52:25

  • related to Bug #15186: Evaluate moving to GitLab for merge requests added

#15 Updated by intrigeri 2018-08-19 07:54:59

intrigeri wrote:
> This could be done in a number of ways:

My current preference is in favour of GitLab CI, be it on Salsa or 0xacab, whichever is more convenient.

#16 Updated by intrigeri 2019-03-08 15:52:38

  • blocks deleted (Feature #8357: Turn the check_PO Jenkins job into a template)

#17 Updated by intrigeri 2019-03-08 15:54:27

  • Status changed from In Progress to Rejected

Whoever imports updated PO files from Transifex already needs to check them before pushing to Git, so testing this again after pushing to Git would be moot.