Bug #8263

Deal with memory requirements check in tails-upgrade-frontend-wrapper vs Jessie

Added by anonym 2014-11-14 17:27:44 . Updated 2015-11-12 07:29:15 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_2.0
Start date:
2014-11-14
Due date:
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Upgrader
Deliverable for:
269

Description

In commit:01c88c1 it was lowered since (at least on the automated test suite’s “hardware”) Jessie doesn’t leave enough free non-buffer/cache memory for tails-upgrade-frontend-wrapper to do the actual upgrade check.

We probably want to do something smarter, or verify that this new number is safe.

Subtasks

Related issues

Related to Tails - Feature #10540: Smarter check for free memory in the Upgrader's wrapper Resolved 2015-11-12
Related to Tails - Feature #8083: Fix automatic upgrades on Jessie Resolved 2014-10-12
Related to Tails - Feature #7986: Re-evaluate hardware requirements on Jessie Resolved 2014-10-02

History

#1 Updated by anonym 2014-11-14 17:35:19

  • Assignee set to intrigeri

In our Live system context, where a lot of stuff is in tmpfs:es, looking at the values of free or /proc/meminfo alone isn’t accurate for determining how much memory “really” is free, since the tmpfs usage is included in the buffers. Hence, MemFree is the lower (and safe) bound of how much “really” free memory we have, and MemFree + Buffers + Cache is the upper (and unsafe) bound. The true value should be (at least closer to) MemFree + Buffers + Cache - (sum of usage by tmpfs:es). We should check once against that value instead.

#2 Updated by intrigeri 2014-12-18 11:53:27

  • blocks Feature #7986: Re-evaluate hardware requirements on Jessie added

#3 Updated by intrigeri 2015-11-12 04:11:55

  • Description updated

#4 Updated by intrigeri 2015-11-12 04:28:55

I agree with anonym’s reasoning above.

Note that I think the explanation in the message for commit:01c88c1 is bogus (MIN_MEMFREE is the safe bound and matters, while MIN_TOTAL_MEMFREE is the unsafe bound that doesn’t matter much).

#5 Updated by intrigeri 2015-11-12 04:46:11

  • related to Feature #10540: Smarter check for free memory in the Upgrader's wrapper added

#6 Updated by intrigeri 2015-11-12 06:39:00

  • related to Feature #8083: Fix automatic upgrades on Jessie added

#7 Updated by intrigeri 2015-11-12 06:39:27

  • blocked by deleted (Feature #7986: Re-evaluate hardware requirements on Jessie)

#8 Updated by intrigeri 2015-11-12 06:39:33

  • related to Feature #7986: Re-evaluate hardware requirements on Jessie added

#9 Updated by intrigeri 2015-11-12 07:26:18

  • Status changed from Confirmed to Resolved
  • % Done changed from 0 to 100

Applied in changeset commit:b8a97e4fe5cfcf265b66eb0ebda724ce24bff122.

#10 Updated by intrigeri 2015-11-12 07:29:15

  • Assignee deleted (intrigeri)
  • Deliverable for set to 269

#11 Updated by intrigeri 2015-11-12 07:29:33

  • blocks #8668 added