Bug #8159

The download management page in Tor Browser doesn't auto update

Added by goupille 2014-10-19 15:58:33 . Updated 2015-09-22 15:10:32 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Start date:
2014-10-19
Due date:
% Done:

100%

Feature Branch:
bugfix/8159-fix-download-management-page
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Browser
Deliverable for:

Description

In the download management page, current downloads seems to have stalled unless one refreshes the page manually

See Tor bug Feature #13579.


Subtasks


History

#1 Updated by BitingBird 2014-10-19 19:16:33

  • Category set to 176

#2 Updated by sajolida 2014-10-20 17:34:24

Did you managed to reproduce this yourself. If so, can you provide the
precise steps that lead to the bug (and the expected results). I don’t
really get what going on…

#3 Updated by intrigeri 2014-10-21 08:50:23

  • Assignee set to goupille
  • QA Check set to Info Needed

#4 Updated by goupille 2014-10-21 17:45:19

to reproduce the bug:

got to https://tails.boum.org/download/index.en.html

start the download of the iso image

go to the Tor Browser menu and open the “Downloads” page

the page show that the file is downloading but the progress bar doesn’t progress, unless you reload the page. the page don’t refresh by itself so even if the file is really being downloaded, it seems stuck.

#5 Updated by BitingBird 2014-10-21 18:29:53

Do you get the same behaviour in TBB, or only in Tails ?

#6 Updated by goupille 2014-10-21 20:35:44

no, with the last Tor Browser, the downloads page works well and show the download’s evolution in real time. I only saw the bug in Tails.

#7 Updated by intrigeri 2014-10-21 20:56:13

  • Target version set to Tails_1.2.1

Is it a regression in Tails 1.2? If yes, please raise priority to elevated, reassign to anonym, and drop the “Info Needed” indication. Thanks!

#8 Updated by goupille 2014-10-22 17:41:15

  • Assignee changed from goupille to anonym
  • Priority changed from Normal to Elevated
  • QA Check deleted (Info Needed)

#9 Updated by anonym 2014-10-30 12:24:09

  • Type of work changed from Research to Code

This upstream Tor bug Feature #13579.

A strange workaround is the following:
1. Click on the all-in-one menu button and then Customize (as in “customize the GUI”)
2. Drag the Downloads button to somewhere on the navigation toolbar
3. Restart the browser (once I didn’t have to do this for some reason)
4. Now the Downloads page updates automatically again

Hopefully there will be an upstream fix soon enough, otherwise that workaround is an option, although it will make us diverge from the Tor Browser’s GUI.

#10 Updated by intrigeri 2014-10-30 13:08:51

  • Type of work changed from Code to Wait

I don’t think it’s worth spending time on a workaround.

#11 Updated by anonym 2014-10-30 15:07:30

  • Assignee deleted (anonym)
  • Priority changed from Elevated to Normal

intrigeri wrote:
> I don’t think it’s worth spending time on a workaround.

Me neither. Downgrading priority and set to wait for an upstream fix.

#12 Updated by intrigeri 2014-10-31 17:05:37

  • Subject changed from download management page in Tor Browser doesn't auto update to The download management page in Tor Browser doesn't auto update

#13 Updated by BitingBird 2014-12-01 10:53:27

  • Description updated

#14 Updated by BitingBird 2014-12-01 10:53:56

  • Description updated

#15 Updated by BitingBird 2014-12-03 19:48:53

  • Target version changed from Tails_1.2.1 to Tails_1.2.2

#16 Updated by anonym 2014-12-12 16:41:58

  • Target version changed from Tails_1.2.2 to Tails_1.2.3

#17 Updated by BitingBird 2015-01-04 17:29:25

  • Category deleted (176)
  • Affected tool set to Browser

#18 Updated by intrigeri 2015-01-13 16:23:10

  • Target version changed from Tails_1.2.3 to Tails_1.4

Not fixed in TBB yet. Let’s come back to it in a while.

#19 Updated by anonym 2015-04-01 21:05:20

  • Assignee set to anonym

This seems to have magically fixed itself in Tor Browser 4.5a5 (or earlier). I’ll keep an eye on this while doing the migration to Tor Browser 4.5.x.

#20 Updated by anonym 2015-04-01 21:11:35

Actually, I can’t seem to reproduce it in Tor Browser 4.0.6 either. Perhaps it’s already fixed (in Tails 1.3.2 or earlier)?

#21 Updated by anonym 2015-04-01 21:36:59

Actually, it seems the problem only appears if I go through the all-in-one menu button -> Downloads. Pressing Ctrl+Alt+Y or going through Tools -> Downloads opens an error-free Download manager page. However, as soon as I open the Download manager page through the all-in-one menu button it breaks, no matter how I open it afterwards.

This also affect Tor Browser 4.5a5… :(

Interestingly, restarting the Tor Browser fixes this. I guess my workaround in Bug #8159#note-9 actually was about that, and that I was wrong about not having to do it “once”. I wonder if it’s relevant that our profile isn’t complete on start, unlike the vanilla Tor Browser.

#22 Updated by anonym 2015-04-29 12:02:51

Still present in Tor Browser 4.5 so I think this ticket will be postponed yet again.

#23 Updated by BitingBird 2015-05-05 20:34:29

  • Target version changed from Tails_1.4 to Tails_1.4.1

Let’s postpone as suggested, no sense keeping a “wait” ticket where we know it won’t be fixed :)

#24 Updated by anonym 2015-07-01 11:55:29

  • Target version changed from Tails_1.4.1 to Tails_1.6

#25 Updated by anonym 2015-09-02 16:57:08

Still an issue in Tails 1.5.1 with Tor Browser 5.0.2.

#26 Updated by anonym 2015-09-08 08:31:56

I can’t blame them, but the Tor Browser devs doesn’t seem very interested in out upstream ticket. Any way, this bug has been polluting my redmine view (and all Release Manager views) for almost a year now. I wonder if we should consider it a Hole in the roof instead.

#27 Updated by anonym 2015-09-08 17:38:53

  • Status changed from Confirmed to In Progress
  • Type of work changed from Wait to Code

So I bisected between a “used” (i.e. started Tor Browser then closed it) ~/.tor-browser with the unused (original) one, and ended up finding that it’s prefs.js that’s the culprit, and specifically that we need to set pref("browser.download.panel.shown", true);.

#28 Updated by anonym 2015-09-08 17:39:18

Applied in changeset commit:cf9cb470dd28f3bb3b9424a0e9cc18229c0db0a7.

#29 Updated by anonym 2015-09-08 17:40:11

  • Assignee deleted (anonym)
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA
  • Feature Branch set to bugfix/8159-fix-download-management-page

#30 Updated by intrigeri 2015-09-15 14:25:06

  • Assignee set to anonym
  • QA Check changed from Ready for QA to Dev Needed

Doesn’t merge cleanly into its base branch.

#31 Updated by anonym 2015-09-16 13:09:14

  • Assignee deleted (anonym)
  • QA Check changed from Dev Needed to Ready for QA

intrigeri wrote:
> Doesn’t merge cleanly into its base branch.

Fixed.

#32 Updated by bertagaz 2015-09-17 06:54:28

  • Assignee set to bertagaz

#33 Updated by bertagaz 2015-09-19 10:40:59

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

Applied in changeset commit:bb560d66c12a3ad55d3d737f038a1bad5e796f54.

#34 Updated by bertagaz 2015-09-19 10:57:48

  • Assignee deleted (bertagaz)
  • QA Check changed from Ready for QA to Pass

#35 Updated by bertagaz 2015-09-22 15:10:32

  • Status changed from Fix committed to Resolved
  • QA Check deleted (Pass)