Bug #8060

The default Tor Browser search engine in Russian is DuckDuckGo

Added by intrigeri 2014-10-11 03:50:42 . Updated 2014-10-16 08:11:21 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Target version:
Tails_1.2
Start date:
2014-10-11
Due date:
% Done:

100%

Feature Branch:
bugfix/8060-fix-default-search-engine
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Browser
Deliverable for:

Description

It should be startpage.

Subtasks

Related issues

Related to Tails - Bug #8036: Localized search plugins are not used by the Tor Browser Resolved 2014-10-09

History

#1 Updated by intrigeri 2014-10-14 02:13:35

Same at least in French and German (build from feature/tor-browser-4.0).

#2 Updated by anonym 2014-10-14 04:58:49

  • related to Bug #8036: Localized search plugins are not used by the Tor Browser added

#3 Updated by anonym 2014-10-14 05:06:52

I know the reason for this, but can’t fully fix it unless Bug #8036 is fixed. The issue is that we call the plugin “Startpage HTTPS” in our branding addon, but the plugin shipped in TBB is called simply “Startpage”. So, we should do this:

diff --git a/config/chroot_local-includes/usr/local/share/tor-browser-extensions/branding@amnesia.boum.org/chrome/locale/ar-EG/amnesia.properties b/config/chroot_local-includes/usr/local/share/tor-browser-extensions/branding@amnesia.boum.org/chrome/locale/ar-EG/amnesia.properties
index c3269ae..fab9fcd 100644
--- a/config/chroot_local-includes/usr/local/share/tor-browser-extensions/branding@amnesia.boum.org/chrome/locale/ar-EG/amnesia.properties
+++ b/config/chroot_local-includes/usr/local/share/tor-browser-extensions/branding@amnesia.boum.org/chrome/locale/ar-EG/amnesia.properties
@@ -1,4 +1,4 @@
-browser.search.defaultenginename=Startpage HTTPS
-browser.search.selectedEngine=Startpage HTTPS
+browser.search.defaultenginename=Startpage
+browser.search.selectedEngine=Startpage
 browser.startup.homepage=https://tails.boum.org/news/
 spellchecker.dictionary=ar_EG
diff --git a/config/chroot_local-includes/usr/local/share/tor-browser-extensions/branding@amnesia.boum.org/chrome/locale/en-US/amnesia.properties b/config/chroot_local-includes/usr/local/share/tor-browser-extensions/branding@amnesia.boum.org/chrome/locale/en-US/amnesia.properties
index f72d0f5..02b4817 100644
--- a/config/chroot_local-includes/usr/local/share/tor-browser-extensions/branding@amnesia.boum.org/chrome/locale/en-US/amnesia.properties
+++ b/config/chroot_local-includes/usr/local/share/tor-browser-extensions/branding@amnesia.boum.org/chrome/locale/en-US/amnesia.properties
@@ -1,4 +1,4 @@
-browser.search.defaultenginename=Startpage HTTPS
-browser.search.selectedEngine=Startpage HTTPS
+browser.search.defaultenginename=Startpage
+browser.search.selectedEngine=Startpage
 browser.startup.homepage=https://tails.boum.org/news/
 spellchecker.dictionary=en_US
diff --git a/config/chroot_local-includes/usr/local/share/tor-browser-extensions/branding@amnesia.boum.org/chrome/locale/zh-CN/amnesia.properties b/config/chroot_local-includes/usr/local/share/tor-browser-extensions/branding@amnesia.boum.org/chrome/locale/zh-CN/amnesia.properties
index f72d0f5..02b4817 100644
--- a/config/chroot_local-includes/usr/local/share/tor-browser-extensions/branding@amnesia.boum.org/chrome/locale/zh-CN/amnesia.properties
+++ b/config/chroot_local-includes/usr/local/share/tor-browser-extensions/branding@amnesia.boum.org/chrome/locale/zh-CN/amnesia.properties
@@ -1,4 +1,4 @@
-browser.search.defaultenginename=Startpage HTTPS
-browser.search.selectedEngine=Startpage HTTPS
+browser.search.defaultenginename=Startpage
+browser.search.selectedEngine=Startpage
 browser.startup.homepage=https://tails.boum.org/news/
 spellchecker.dictionary=en_US

This will fix the problem for Russian, since it doesn’t have its locale defined in our branding addon, and will fallback to en-US. However, all locales that set a localized plugin (e.g. French) will still be broken. When Bug #8036 is solved, fixing all this will be easy.

#4 Updated by anonym 2014-10-14 09:21:33

  • related to deleted (Bug #8036: Localized search plugins are not used by the Tor Browser)

#5 Updated by anonym 2014-10-14 09:21:41

  • blocked by Bug #8036: Localized search plugins are not used by the Tor Browser added

#6 Updated by anonym 2014-10-14 10:21:20

  • Status changed from Confirmed to In Progress
  • Assignee deleted (anonym)
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA
  • Feature Branch set to bugfix/8060-fix-default-search-engine

Still, blocked by Bug #8036.

#7 Updated by intrigeri 2014-10-15 05:36:46

  • Assignee set to intrigeri
  • % Done changed from 50 to 60

Code looks good.

#8 Updated by intrigeri 2014-10-15 08:18:13

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)
  • % Done changed from 60 to 100
  • QA Check changed from Ready for QA to Pass

#9 Updated by intrigeri 2014-10-15 08:22:15

  • blocks deleted (Bug #8036: Localized search plugins are not used by the Tor Browser)

#10 Updated by intrigeri 2014-10-15 08:22:20

  • related to Bug #8036: Localized search plugins are not used by the Tor Browser added

#11 Updated by anonym 2014-10-16 08:11:22

  • Status changed from Fix committed to Resolved