Bug #8037

No more localized Wikipedia search engines

Added by intrigeri 2014-10-09 06:38:50 . Updated 2014-10-16 08:11:10 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Target version:
Start date:
2014-10-09
Due date:
% Done:

100%

Feature Branch:
bugfix/8037-install-localized-wikipedia-searchplugins
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Browser
Deliverable for:

Description

In 1.2~rc1, I don’t see any localized Wikipedia search engine in the browser anymore. I guess they were shipped as part of the Iceweasel package’s delta. Maybe it’s acceptable to have this regression, but IMO we should first investigate how hard it would be to get these back in some way (e.g. by pulling them from iceweasel’s Git at ISO build time).


Subtasks


Related issues

Related to Tails - Bug #8036: Localized search plugins are not used by the Tor Browser Resolved 2014-10-09
Related to Tails - Bug #8139: No more localized search engines except Wikipedia Resolved 2014-10-16

History

#1 Updated by anonym 2014-10-09 07:02:21

Would another acceptable solution be to do exactly what we do for the localized startpate plugins? E.g. store them in config/chroot_local-includes/usr/share/amnesia/browser/searchplugins/.

#2 Updated by intrigeri 2014-10-09 07:29:19

> Would another acceptable solution be to do exactly what we do for the localized
> startpate plugins? E.g. store them in
> config/chroot_local-includes/usr/share/amnesia/browser/searchplugins/.

I think the reason we do that for Startpage is that there’s no good way to get this set of plugins, all at once, from a well-maintained place. As a result, we have to maintain them ourselves. It would be good if we at least tried to avoid this situation for the Wikipedia ones.

#3 Updated by anonym 2014-10-09 08:24:09

intrigeri wrote:
> It would be good if we at least tried to avoid this situation for the Wikipedia ones.

Sure. It just that the suggested approach of automatically pulling them from Iceweasel’s Git brings the problem of automatically authenticating them (if we rely on tags we may have to pull a looooong Git history). And to use the build system’s caching proxy.

Maybe the easiest is to apt-get download the appropriate iceweasel-l10n packages and extract it from there? Then we get those things for free.

#4 Updated by intrigeri 2014-10-09 09:18:50

> Sure. It just that the suggested approach of automatically pulling them from
> Iceweasel’s Git brings the problem of automatically authenticating them (if we rely
> on tags we may have to pull a looooong Git history). And to use the build system’s caching proxy.

Indeed.

I would find it acceptable to rely on HTTPS, and to pull stuff from cgit, e.g. https://anonscm.debian.org/cgit/pkg-mozilla/iceweasel.git/tree/l10n-de/browser/searchplugins?h=esr31/master (which shows, BTW, that we didn’t lose the Wikipedia search engines only: more localized search engines are shipped in the Firefox l10n packs).

Or straight from upstream, e.g. https://hg.mozilla.org/l10n-central/de/file/843fc6aadf15/browser/searchplugins (absolutely not the best place to get files that match the ESR we use, see debian/upstream.mk in the Iceweasel source package to find our where the plugins that we used to ship actually came from — but you get the idea).

> Maybe the easiest is to apt-get download the appropriate iceweasel-l10n packages
> and extract it from there? Then we get those things for free.

Assuming a close-enough ESR version is packaged whenever we need it, yes, that’s probably the easiest. It might be cheaper to apt-get source iceweasel and get the files from l10n-*/browser/searchplugins in there, by the way.

And now I’m wondering if Tails is the best place to do this on the mid-term. It would be good to ask the TBB team whether they would take patches that includes these localized search plugins in their tarballs.

#5 Updated by anonym 2014-10-14 09:20:25

  • Status changed from Confirmed to In Progress
  • Assignee deleted (anonym)
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA
  • Feature Branch set to bugfix/8037-install-localized-wikipedia-searchplugins

The branch feature branch solves the first part of the issue, which is installing the search plugins. However, we’re blocked by the underlying issue of Bug #8036, i.e. that the Tor Browser doesn’t use the localized searchplugins at all.

#6 Updated by anonym 2014-10-14 09:20:40

  • blocked by Bug #8036: Localized search plugins are not used by the Tor Browser added

#7 Updated by intrigeri 2014-10-15 05:33:04

  • Assignee set to intrigeri
  • % Done changed from 50 to 60

Code looks good.

#8 Updated by intrigeri 2014-10-15 08:18:47

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)
  • % Done changed from 60 to 100
  • QA Check changed from Ready for QA to Pass

#9 Updated by intrigeri 2014-10-15 08:22:01

  • blocks deleted (Bug #8036: Localized search plugins are not used by the Tor Browser)

#10 Updated by intrigeri 2014-10-15 08:22:07

  • related to Bug #8036: Localized search plugins are not used by the Tor Browser added

#11 Updated by intrigeri 2014-10-16 03:01:41

  • related to Bug #8139: No more localized search engines except Wikipedia added

#12 Updated by anonym 2014-10-16 08:11:10

  • Status changed from Fix committed to Resolved