Bug #8035

Amnesia branding extension is installed in the Unsafe Browser

Added by intrigeri 2014-10-09 06:10:06 . Updated 2014-10-16 08:11:08 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Target version:
Tails_1.2
Start date:
2014-10-09
Due date:
% Done:

100%

Feature Branch:
bugfix/8035-remove-branding-extension-in-unsafe-browser
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Unsafe Browser
Deliverable for:

Description

(discovered while testing 1.2~rc1)

Subtasks

History

#1 Updated by anonym 2014-10-09 06:57:22

  • Assignee deleted (anonym)
  • QA Check set to Info Needed

I guess I assumed that it was installed prior to the TBB-migration, cause I explicitly enabled that extension after the TBB-migration (see commit aad3cb3). OTOH, isn’t the additional localization from this actually a feature?

#2 Updated by intrigeri 2014-10-09 09:01:52

  • Assignee set to anonym
  • QA Check deleted (Info Needed)

anonym wrote:
> I guess I assumed that it was installed prior to the TBB-migration, cause I explicitly enabled that extension after the TBB-migration (see commit aad3cb3).

This was not the case:

  • verified in Tails 1.1.2
  • our manual test suite reads “no extensions are installed”, so we’ve actually verified it was the case for every release since a while

> OTOH, isn’t the additional localization from this actually a feature?

Yes, but it’s not only about localization. E.g. it sets the homepage to the localized version of our homepage (which is overriden by something else in the context of the Unsafe Browser, apparently), and it might be that we add features to this add-on in the future that make it less and less suitable for the Unsafe Browser usecase. I’m unsure, so I’d rather see us keep the status quo.

#3 Updated by anonym 2014-10-09 10:43:02

Ok, I’m convinced. It should be as easy as

--- a/config/chroot_local-includes/usr/local/sbin/unsafe-browser
+++ b/config/chroot_local-includes/usr/local/sbin/unsafe-browser
@@ -160,7 +160,6 @@ configure_chroot () {
     CLEARNET_EXT="${CLEARNET_PROFILE}"/extensions
     mkdir -p "${CLEARNET_EXT}"
     cp -Pr "${TBB_PROFILE}"/extensions/langpack-*.xpi \
-           "${TBB_PROFILE}"/extensions/branding@amnesia.boum.org \
            "${CLEARNET_EXT}"

     CLEARNET_PREFS="${CLEARNET_PROFILE}"/preferences/prefs.js


but I’ll test it etc later.

#4 Updated by anonym 2014-10-10 04:20:26

  • Status changed from Confirmed to In Progress
  • Assignee deleted (anonym)
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA
  • Feature Branch set to bugfix/8035-remove-branding-extension-in-unsafe-browser

#5 Updated by anonym 2014-10-10 05:22:34

  • Assignee set to intrigeri

#6 Updated by intrigeri 2014-10-11 01:00:19

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)
  • % Done changed from 50 to 100
  • QA Check changed from Ready for QA to Pass

#7 Updated by anonym 2014-10-16 08:11:08

  • Status changed from Fix committed to Resolved