Bug #8031

Refactor 10-tbb hook

Added by anonym 2014-10-08 08:01:12 . Updated 2014-10-16 08:11:15 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_1.2
Start date:
2014-10-08
Due date:
% Done:

100%

Feature Branch:
feature/8031-refactor-10-rbb-hook
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Browser
Deliverable for:

Description

See: https://mailman.boum.org/pipermail/tails-dev/2014-September/006960.html

Subtasks

History

#1 Updated by anonym 2014-10-09 17:32:47

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 40
  • Feature Branch set to feature/8031-refactor-10-rbb-hook

Pushed some work, but it hasn’t been tested fully yet.

#2 Updated by anonym 2014-10-10 02:52:14

  • Assignee changed from anonym to intrigeri
  • % Done changed from 40 to 50
  • QA Check set to Ready for QA

I manually tested all three browsers (Tor, Unsafe, I2P) with en-US and ru chosen in Tails Greeter, and bridge mode on, and I couldn’t see any regression. Also ran the automated test suite successfully for the features that uses the browser (features/torified_browsing.feature features/unsafe_browser.feature features/windows_camouflage.feature features/firewall_leaks.feature features/i2p.feature).

#3 Updated by intrigeri 2014-10-11 03:41:32

  • Assignee changed from intrigeri to anonym
  • % Done changed from 50 to 70
  • QA Check changed from Ready for QA to Dev Needed

Merged the current state, still a little bit of work remaining, see -dev@.

#4 Updated by anonym 2014-10-13 08:55:04

  • Assignee changed from anonym to intrigeri
  • QA Check changed from Dev Needed to Ready for QA

I think all concerns raised on tails-dev@ have been fixed.

#5 Updated by intrigeri 2014-10-13 13:19:23

  • Assignee changed from intrigeri to anonym
  • QA Check changed from Ready for QA to Dev Needed

See review on -dev@.

#6 Updated by anonym 2014-10-14 02:30:05

  • Assignee changed from anonym to intrigeri
  • QA Check changed from Dev Needed to Ready for QA

#7 Updated by intrigeri 2014-10-14 02:45:26

  • Assignee changed from intrigeri to anonym
  • QA Check changed from Ready for QA to Dev Needed

Please reassign to me, and flag as ready for QA, once the current testing branch has been merged into this one. Thanks!

#8 Updated by anonym 2014-10-14 05:51:33

  • Assignee changed from anonym to intrigeri
  • QA Check changed from Dev Needed to Ready for QA

#9 Updated by intrigeri 2014-10-15 05:33:41

Code looks good.

#10 Updated by intrigeri 2014-10-15 08:18:32

  • Assignee deleted (intrigeri)
  • % Done changed from 70 to 100
  • QA Check changed from Ready for QA to Pass

#11 Updated by intrigeri 2014-10-15 08:19:15

  • Status changed from In Progress to Fix committed

#12 Updated by anonym 2014-10-16 08:11:16

  • Status changed from Fix committed to Resolved