Tails

#1 Updated by intrigeri 2014-09-29 08:29:56

• blocks Feature #6507: Package our OpenPGP applet for Debian and maintain it there added

#2 Updated by nodens 2014-11-11 12:59:38

• Assignee set to nodens

#3 Updated by nodens 2014-11-11 17:32:11

• Status changed from Confirmed to Fix committed
• Assignee deleted (nodens)
• % Done changed from 0 to 60
• QA Check set to Ready for QA
• Type of work changed from Research to Code

Ok, figured that one out.

The data from gpg is encoded before being passed to the GTK2 clipboard, and GTK2 encodes it as well, so we end up with doubled-encoded data.

Doesn’t affect anything other than clearsign, since everything else is armored. Also, the X primary clipboard is unaffected as well.

Fixed in bugfix/7968-cant-clearsign-non-ascii-text branch of the OpenPGP applet repository, I don’t think I can commit to the main tail repo, so please get it there :
https://git-tails.immerda.ch/nodens/openpgp-applet/commit/?h=bugfix/7968-cant-clearsign-non-ascii-text

Cheers,

#4 Updated by nodens 2014-11-11 17:36:27

• Assignee set to intrigeri

#6 Updated by intrigeri 2014-11-12 10:17:54

• Status changed from Fix committed to In Progress

#7 Updated by intrigeri 2014-11-12 10:18:30

• Target version set to Tails_1.2.1

#8 Updated by sajolida 2014-11-12 10:50:56

• Assignee deleted (intrigeri)
• Target version changed from Tails_1.2.1 to Tails_1.3
• Feature Branch set to bugfix/7968-cant-clearsign-non-ascii-text

Hi, the review and merge process is described here:

https://tails.boum.org/contribute/merge_policy/

According to this you should:

• Assign this ticket to nobody. I did that for you.
• Set the ticket’s Target version. We already passed the freeze for 1.2.1 so this will go into 1.3 only, Done as well.
• Ask for a review and merge on tails-dev@boum.org. I can’t really do that for you.

#9 Updated by intrigeri 2014-11-13 12:18:07

• Assignee set to intrigeri
• Target version changed from Tails_1.3 to Tails_1.2.1

sajolida, thanks for your guidance and input. There are specifics to this ticket that make the general rules not necessarily applicable, though:

• I’ve been reviewing nodens’ work since he started working on this applet, and I have the problem space in mind, so it did make sense to assign it to me. (Also, given nodens’ work is based on his own Git repo of the applet, which we don’t use yet, and I think I’m the only one to ever have looked at, he had yet another good reason to assign this ticket to me :)
• The freeze is about features, but generally bugfixes (assuming they’re not too risky) are welcome. That’s why I had set the target version to 1.2.1, and am reverting your change.

#11 Updated by anonym 2014-11-14 12:04:03

• Status changed from In Progress to Fix committed
• Assignee deleted (intrigeri)
• % Done changed from 60 to 100
• QA Check changed from Ready for QA to Pass

nodens wrote:
> Just FYI : I did test the change on an old version of my applet far closer to the code Tails is using, on Squeeze and Wheezy virtual machines, so I’m pretty confident the fix will work in stable. I didn’t test it in Tails, though.

I’ve tested the fix, and it works (i.e. the resulting clearsigns pasted via Ctrl+V are now OK, just like the middle-click-pasted ones). Merged (after fixing the indentation for the comment)! Thanks for the patch, nodens!

I some how failed to see that this ticket already was assigned to you, intrigeri, but I doubt that you’ll be sad about me taking care of this.

#13 Updated by BitingBird 2014-12-03 19:41:35

• Status changed from Fix committed to Resolved

#14 Updated by nodens 2015-08-18 12:21:53

• blocked by deleted (Feature #6507: Package our OpenPGP applet for Debian and maintain it there)

#15 Updated by intrigeri 2015-08-19 02:47:20

• blocks Feature #6507: Package our OpenPGP applet for Debian and maintain it there added

#16 Updated by intrigeri 2015-08-19 02:49:42

• Affected tool set to OpenPGP Applet