Bug #7944

Tails' browser bookmarks not present after TBB migration

Added by anonym 2014-09-24 07:32:55 . Updated 2014-09-30 10:28:31 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Test suite
Target version:
Tails_1.2
Start date:
2014-09-24
Due date:
% Done:

100%

Feature Branch:
feature/tor-browser-bundle
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

After the TBB migration (feature/tor-browser-bundle) it seems we cannot rely on having out bookmarks.html in the profile skeleton in order to get the browser to import them. TBB packs its own bookmarks.html in the (zip archive) feature/tor-browser-bundle, at defaults/profile/bookmarks.html, which will override this file.

To fix this we could (at build time) put our bookmarks.html in there, replacing TBB’s. Alternatively we could try to just remove it from the archive.

Subtasks

History

#1 Updated by anonym 2014-09-25 18:39:31

The zip archive mentioned in the description should be /usr/local/lib/tor-browser/Browser/browser/omni.ja, but there was a copy-paste error. I can’t find how to edit the description, but perhaps it’s because I’m not a redmine manager any more?

#2 Updated by intrigeri 2014-09-25 19:02:45

> I can’t find how to edit the description, but perhaps it’s because I’m not a redmine manager any more?

I made you a “manager” again. You can tweak your personal prefs to
avoid receiving all ticket updates.

#3 Updated by anonym 2014-09-26 10:40:19

  • Status changed from Confirmed to Fix committed
  • Assignee deleted (anonym)
  • % Done changed from 0 to 100
  • QA Check set to Pass

I had the reason for this bug completely wrong, see commit 9b71212 which fixes it.

#4 Updated by intrigeri 2014-09-27 09:28:23

  • Status changed from Fix committed to Resolved
  • Assignee set to anonym
  • % Done changed from 100 to 0
  • Parent task set to Feature #7953
  • QA Check deleted (Pass)

#5 Updated by anonym 2014-09-28 17:01:12

  • Assignee deleted (anonym)
  • % Done changed from 0 to 100

#6 Updated by intrigeri 2014-09-29 09:01:21

  • Category changed from 176 to Test suite
  • Status changed from Resolved to In Progress
  • Assignee set to anonym
  • % Done changed from 100 to 90
  • QA Check set to Info Needed

Can you please confirm that you’ve tested (either manually or automatically) that the bookmarks persistence feature still works with this change applied and commit ab5259ec (Block disk usage in the Tor Browser via Torbutton)?

(The Git history shows that the disk usage blocking was added later, so I just want to make sure, and my automated testing environment is broken right now (Feature #7212) so I can’t verify myself super-easily.)

#7 Updated by anonym 2014-09-29 16:12:38

  • Status changed from In Progress to Resolved
  • Assignee deleted (anonym)
  • % Done changed from 90 to 100
  • QA Check deleted (Info Needed)

intrigeri wrote:
> Can you please confirm that you’ve tested (either manually or automatically) that the bookmarks persistence feature still works with this change applied and commit ab5259ec (Block disk usage in the Tor Browser via Torbutton)?

It passes.

#8 Updated by intrigeri 2014-09-30 10:28:31

> It passes.

Thanks for helping me be more confident :)