Tails

#1 Updated by intrigeri 2014-10-20 14:04:55

• blocked by #8117 added

#2 Updated by intrigeri 2014-10-20 14:05:04

• blocks deleted (#8117)

#3 Updated by intrigeri 2014-10-20 14:05:08

• blocks #8117 added

#4 Updated by anonym 2014-12-12 16:41:54

• Target version changed from Tails_1.2.2 to Tails_1.2.3

#5 Updated by BitingBird 2015-01-07 18:11:12

• Affected tool set to Unsafe Browser

#6 Updated by anonym 2015-01-13 14:14:42

• Target version changed from Tails_1.2.3 to Tails_1.3

#7 Updated by Tails 2015-01-30 16:24:08

• Status changed from Confirmed to In Progress

Applied in changeset commit:02cd3e945e6393233bc2d09e7b979a3941cec7b0.

#8 Updated by anonym 2015-02-01 15:28:40

• Assignee changed from anonym to kytv
• % Done changed from 0 to 50
• QA Check set to Ready for QA
• Feature Branch set to test/7823-unsafe-browser

#9 Updated by kytv 2015-02-03 21:54:12

• Assignee deleted (kytv)
• % Done changed from 50 to 90
• QA Check changed from Ready for QA to Pass

Changes look good, runs successfully (when not hitting Bug #8686), and tests what it’s supposed to test.

+1 on merging. :)

#10 Updated by intrigeri 2015-02-03 23:37:04

• Assignee set to intrigeri

#11 Updated by intrigeri 2015-02-04 00:09:35

• Assignee changed from intrigeri to anonym
• QA Check changed from Pass to Info Needed

I’m fine with merging this branch up to, and including, commit:02cd3e945e6393233bc2d09e7b979a3941cec7b0. But I don’t understand how the two next commits on that branch are related.

#12 Updated by anonym 2015-02-04 08:29:26

• Assignee changed from anonym to intrigeri
• QA Check changed from Info Needed to Ready for QA

intrigeri wrote:
> I’m fine with merging this branch up to, and including, commit:02cd3e945e6393233bc2d09e7b979a3941cec7b0. But I don’t understand how the two next commits on that branch are related.

I should have explained its inclusion better. It’s a pretty damn usable script when developing and debugging tests. Example: let’s say I’ve added some @vm.execute(cmd) but something was wrong with cmd so the test fails. Since I ran the test suite with --pause-on-fail the VM and its remote shell are still running. I can then use the vm-execute to revise cmd without having to restart the whole test, which takes time. Also, if a test fails and I want to inquire what went wrong I often find running some command via the remote shell much more convenient than starting virt-viewer and then start GNOME Terminal (and generally we’ll be without root access then, unlike with the remote shell).

I could put those commits in a separate branch, if you so prefer.

#14 Updated by intrigeri 2015-02-04 09:26:57

• Assignee changed from intrigeri to anonym
• QA Check changed from Ready for QA to Info Needed

#15 Updated by anonym 2015-02-04 09:30:45

• Assignee changed from anonym to intrigeri
• QA Check changed from Info Needed to Ready for QA

intrigeri wrote:
> > I should have explained its inclusion better. It’s a pretty damn usable script when developing and debugging tests.
>
> OK, cool. And it does work with that hard-coded 1337 remote shell port?

Yes, it’s hardcoded inside the test suite too (features/domains/default.xml).

> Or does it need manual tweaking?

No tweaking needed.

> > I could put those commits in a separate branch, if you so prefer.
>
> Let’s try to merge it at the same time, first. If the questions I’m asking above result in “needs more dev”, then yes please.

Merge!

#16 Updated by Tails 2015-02-04 09:32:11

• Status changed from In Progress to Fix committed
• % Done changed from 90 to 100

Applied in changeset commit:676127b0cd939b5443a6849b57128729b71276e1.

#17 Updated by intrigeri 2015-02-04 09:32:38

• Assignee deleted (intrigeri)
• QA Check changed from Ready for QA to Pass

#18 Updated by BitingBird 2015-02-24 22:49:50

• Status changed from Fix committed to Resolved