Feature #7804

Use Test::Unit::Assertions instead of home-made assert()

Added by intrigeri 2014-08-23 18:05:31 . Updated 2014-10-16 08:10:56 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
Start date:
2014-08-23
Due date:
% Done:

100%

Feature Branch:
test/7804-test-unit-assertions
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description


Subtasks


History

#1 Updated by intrigeri 2014-08-23 18:06:33

This might do the job:

diff --git a/features/support/helpers/misc_helpers.rb
b/features/support/helpers/misc_helpers.rb
index 533816f..eee0ebe 100644
--- a/features/support/helpers/misc_helpers.rb
+++ b/features/support/helpers/misc_helpers.rb
@@ -1,9 +1,9 @@
 require 'date'
 require 'timeout'
+require 'test/unit'

-def assert(b, msg = "Assertion failed!")
-  raise RuntimeError, msg, caller if ! b
-end
+# Make all the assert_* methods easily accessible in any context.
+include Test::Unit::Assertions

 # Call block (ignoring any exceptions it may throw) repeatedly with one
 # second breaks until it returns true, or until `t` seconds have

… and then we can convert some of our assert() to more suitable assert_*().

#2 Updated by intrigeri 2014-09-17 19:03:17

  • Feature Branch set to test/7804-test-unit-assertions

#3 Updated by intrigeri 2014-09-17 19:32:58

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 10

#4 Updated by intrigeri 2014-09-18 09:15:32

  • Assignee deleted (intrigeri)
  • Target version set to Tails_1.2
  • % Done changed from 10 to 50
  • QA Check set to Ready for QA

#5 Updated by intrigeri 2014-09-18 09:19:20

  • Assignee set to anonym

#6 Updated by anonym 2014-09-25 17:39:18

  • Status changed from In Progress to Fix committed
  • Assignee deleted (anonym)
  • % Done changed from 50 to 100
  • QA Check changed from Ready for QA to Pass

#7 Updated by sajolida 2014-10-14 15:44:00

  • blocks #8117 added

#8 Updated by anonym 2014-10-16 08:10:56

  • Status changed from Fix committed to Resolved