Bug #7797

WhisperBack prevents user from removing optional PGP keyblock once they have entered one

Added by emmapeel 2014-08-19 06:33:32 . Updated 2018-05-10 11:07:58 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_3.7
Start date:
2014-08-19
Due date:
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
1
Affected tool:
WhisperBack
Deliverable for:

Description

The code lives in https://git-tails.immerda.ch/whisperback.

Steps to reproduce

  1. Create a bug report.
  2. Add an optional email address.
  3. Click on “optional PGP key”.
  4. Add a valid PGP key block.
  5. Click “ok”.
  6. Click on “optional PGP key”.
  7. Remove the contents of the PGP key block.
  8. Click “ok”.
  9. A warning message appears saying “This doesn’t seem to be a valid URL or OpenPGP key.”
  10. Close the message and click “Cancel.”
  11. Click on “optional PGP key.”

Actual result and description of the error

The public key block is still present. If one tries to remove it, WhisperBack prevents the removal. Sometimes it crashes, too (can’t reproduce but happened a few times).

Desired result

There should be a way to empty the textbox in “optional PGP key” so that if the user changes his mind about giving email information with a PGP key, he can without having to close WhisperBack and rewriting all his bug information.

Files

0001-bugfix-7797-Allow-empty-GPG-Key.patch (886 B) sascha.markus@gmail.com, 2018-03-26 20:40:15

Subtasks

Related issues

Has duplicate Tails - Bug #9227: Add ability to remove a previously added PGP key in WhisperBack Duplicate 2015-04-11
Blocked by Tails - Bug #15440: Missing WhisperBack 1.7.14 in Git Resolved 2018-03-22

History

#1 Updated by emmapeel 2014-08-19 06:48:41

  • Assignee set to alant

Assigning to alant to ‘ping’ him. I could reproduce this in my Tails too.

#2 Updated by sajolida 2014-08-19 09:05:06

  • Status changed from New to Confirmed

#3 Updated by BitingBird 2015-01-08 04:04:10

  • Assignee deleted (alant)
  • Starter changed from Yes to No

removing alant from assignee -> anyone might work on that :)

Removing the “easy” tag, as the ticket is not this well-defined.

#4 Updated by intrigeri 2015-01-08 10:40:10

  • Description updated
  • Starter changed from No to Yes

#5 Updated by BitingBird 2015-04-11 20:51:27

  • has duplicate Bug #9227: Add ability to remove a previously added PGP key in WhisperBack added

#6 Updated by intrigeri 2015-06-05 15:46:00

Presumably, allowing empty content in all cases, when clicking OK, would be good enough.

#7 Updated by Anonymous 2017-06-29 15:10:36

Confirmed this is still present on 3.0.

#8 Updated by sascha.markus@gmail.com 2018-03-26 20:41:18

Patch to allow empty input

#9 Updated by intrigeri 2018-03-27 08:58:43

  • Assignee set to anonym
  • Target version set to Tails_3.7
  • QA Check set to Ready for QA

Thanks for the patch!

#10 Updated by intrigeri 2018-04-13 11:36:49

  • Assignee changed from anonym to intrigeri

#11 Updated by intrigeri 2018-04-13 16:13:56

  • blocked by Bug #15440: Missing WhisperBack 1.7.14 in Git added

#12 Updated by intrigeri 2018-04-14 07:26:46

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 90

Code review passes and quick testing works => I’ll merge this once Bug #15440 is done.

#13 Updated by intrigeri 2018-04-14 07:32:13

  • QA Check changed from Ready for QA to Pass

#14 Updated by intrigeri 2018-05-07 12:37:37

  • Assignee changed from intrigeri to bertagaz

Merged, will be fixed once bertagaz releases a new WhisperBack!

#15 Updated by bertagaz 2018-05-10 11:07:58

  • Status changed from In Progress to Resolved
  • Assignee deleted (bertagaz)
  • % Done changed from 90 to 100

intrigeri wrote:
> Merged, will be fixed once bertagaz releases a new WhisperBack!

It’s been released!