Bug #7716

Tails Installer should not run update_system_partition_properties on MBR partitions

Added by sajolida 2014-08-01 18:34:38 . Updated 2014-09-02 05:15:57 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Installation
Target version:
Tails_1.1.1
Start date:
2014-08-01
Due date:
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
1
Affected tool:
Deliverable for:

Description

From WhisperBack report 4d062594b54740b1f53a3a64c4c7032d.

While doing an “Upgrade from ISO”, someone got the following trace:

tails-i386-1.1.iso selected
Unmounting mounted filesystems on '/dev/sdd1'
[...]
Updating properties of system partition /dev/sdd1
Error modifying partition: helper exited with exit code 1: In part_change_partition: device_file=/dev/sdd, start=31744, new_start=31744, new_size=3929335808, type=XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXXX
Entering MS-DOS parser (offset=0, size=3930062848)
MSDOS_MAGIC found
looking at part 0 (offset 31744, size 3929335808, type 0x0c)
new part entry
looking at part 1 (offset 0, size 0, type 0x00)
new part entry
looking at part 2 (offset 0, size 0, type 0x00)
new part entry
looking at part 3 (offset 0, size 0, type 0x00)
new part entry
Exiting MS-DOS parser
MSDOS partition table detected
containing partition table scheme = 0
invalid type 'XXXXXXXX-XXXX-XXXX-XXXXXXXXXXXX' given

It seems like they have a MBR partition table, which means that the device was not installed with Tails Installer, but most likely with the UUI. It seems that Tails Installer (when doing any kind of upgrade) should check what partition table the destination device has, and only run update_system_partition_properties() if that’s a GPT.

The code lives in https://git-tails.immerda.ch/liveusb-creator. We already have helpers to talk to udisks there, and likely the needed info is already available in some object attribute.

That’s a regression in 1.1, maybe not a blocker for 1.1.1.

Subtasks

History

#1 Updated by intrigeri 2014-08-02 10:22:11

  • Description updated
  • Assignee set to kurono
  • Starter set to Yes

(Improved description => flagged as Easy.)

kurono, do you want to give it a try? If you do, please adjust the target version field according to your ETA. Otherwise, just deassign this ticket from you. Thanks!

#2 Updated by kurono 2014-08-03 21:17:19

Ok I’ll do it.

#3 Updated by kurono 2014-08-07 22:17:28

  • QA Check set to Ready for QA

#4 Updated by intrigeri 2014-08-08 11:31:09

  • % Done changed from 0 to 20

Thanks! kurono, when flagging a ticket as ready for QA, please deassign it from you, so that it’s clear that nobody volunteered yet to take care of the review. The process is documented on https://tails.boum.org/contribute/merge_policy/#index2h1.

#5 Updated by intrigeri 2014-08-08 11:31:29

  • Assignee changed from kurono to intrigeri

#6 Updated by intrigeri 2014-08-08 11:31:47

  • Status changed from Confirmed to In Progress

#7 Updated by intrigeri 2014-08-08 13:15:50

  • Assignee changed from intrigeri to kurono
  • QA Check changed from Ready for QA to Info Needed

Patch sent on tails-dev@, replied there.

#8 Updated by kurono 2014-08-26 17:47:59

  • QA Check changed from Info Needed to Ready for QA

#9 Updated by intrigeri 2014-08-26 17:51:02

  • Assignee deleted (kurono)
  • % Done changed from 20 to 30

#10 Updated by anonym 2014-08-29 13:15:56

  • Status changed from In Progress to Fix committed
  • % Done changed from 30 to 100
  • QA Check changed from Ready for QA to Pass

Thanks for the patch, kurono!

#11 Updated by anonym 2014-09-02 05:15:57

  • Status changed from Fix committed to Resolved