Bug #7654

Tails Installer crashes if any UUID includes Unicode character

Added by sajolida 2014-07-24 17:54:21 . Updated 2018-08-18 14:27:13 .

Status:
Confirmed
Priority:
Normal
Assignee:
Category:
Installation
Target version:
Start date:
Due date:
% Done:

0%

Feature Branch:
Type of work:
Research
Blueprint:

Starter:
0
Affected tool:
Installer
Deliverable for:

Description

Someone reported us that Tails Installer crashes if any UUID on the
system includes a Unicode character. Apparently, this could happen with
some disk encryption software for Windows. Then, even if that UUID is on
the local hard disk, Tails Installer crashes:

amnesiaamnesia:~$ liveusb-creator -u -n —clone -P -m -x -v@
Bus::open: Can not get ibus-daemon's address.
IBusInputContext::createInputContext: no connection to ibus-daemon
[creator:1188] extlinux not found! Only FAT filesystems will be
supported
[creator:663] Skipping device '/org/freedesktop/UDisks/devices/sda1'
connected to 'ata' interface
Traceback (most recent call last):
@ File “/usr/lib/python2.7/dist-packages/dbus/connection.py”, line @
604, in msg_reply_handler
@ reply_handler(message.get_args_list(*get_args_opts))@
@ File “/usr/lib/python2.7/dist-packages/liveusb/creator.py”, line @
647, in handle_reply
@ ‘uuid’: str(dev.Get(device, ‘IdUuid’)),@
UnicodeEncodeError: 'ascii' codec can't encode character u'\u0297' in
position 18: ordinal not in range(128)

The reporter says that this can be solved by changing str() to unicode()
on line 647 of creator.py.

Someone knowledgeable about the internals of the installer should
investigate whether this fix could be applied with no risk.


Subtasks


Related issues

Related to Tails - Feature #15292: Distribute a USB image Resolved 2016-04-14 2019-01-29

History

#1 Updated by BitingBird 2014-07-24 18:24:40

  • Category set to Installation
  • Starter set to No

#2 Updated by intrigeri 2014-12-01 18:54:03

  • blocked by Bug #8331: Merge liveusb-creator upstream changes added

#3 Updated by intrigeri 2014-12-01 18:54:30

Upstream has supposedly fixed all such bugs recently.

#4 Updated by BitingBird 2015-01-04 19:00:54

  • Affected tool set to Installer

#5 Updated by intrigeri 2016-07-22 03:16:54

  • blocks deleted (Bug #8331: Merge liveusb-creator upstream changes)

#6 Updated by Anonymous 2018-08-18 13:13:59

#7 Updated by Anonymous 2018-08-18 13:14:37

  • Status changed from Confirmed to Rejected

Upstream is supposed to have fixed this. No news on this ticket with similar reports since 3 years. → closing.

#8 Updated by intrigeri 2018-08-18 14:27:13

  • Status changed from Rejected to Confirmed

> Upstream is supposed to have fixed this.

I think there’s a misunderstanding: with “upstream”, back then we meant the original liveusb-creator code base we’ve forked 7 years ago. But we never brought these fixes to Tails Installer.