Bug #7647

Hide Torbutton "Open Network Settings" menu entry when the Tor Launcher is not enabled

Added by dct 2014-07-23 12:42:23 . Updated 2015-05-12 18:46:00 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_1.4
Start date:
2014-07-23
Due date:
% Done:

100%

Feature Branch:
feature/9031-tor-browser-4.5
Type of work:
Code
Blueprint:

Starter:
0
Affected tool:
Browser
Deliverable for:

Description

Using latest Iceweasel (24.7.0). Not sure if this is for Tails or for upstream, but nothing happens when clicking “Open Network Settings” in the Torbutton menu item.

Subtasks

Related issues

Blocked by Tails - Feature #9031: Upgrade to Tor Browser 4.5 Resolved 2015-03-26

History

#1 Updated by intrigeri 2014-07-27 16:12:36

  • Subject changed from Torbutton "Open Network Settings" to Hide Torbutton "Open Network Settings" menu entry
  • Status changed from New to Confirmed
  • Target version deleted (Tails_1.1.1)

I can reproduce this on 1.1 (+ some other branches, but should not be significant). I doubt that’s a regression, so dropping the 1.1.1 target version. It works fine with the TBB 3.6.3, most likely by calling some Tor Launcher function.

The features that are offered there won’t make any sense for Tails anyway, as our own Tor browser doesn’t control Tor: only our Tor Launcher can do that, and we don’t ship it as an extension in Tor browser, but run it as a dedicated user. And, we don’t really support reconfiguring Tor once the Launcher has exited.

So, IMO, the only fix I can think of is to hide this menu entry. Ideally, we would upstream an option to hide it, or (better!) have Torbutton detect if the function that this menu entry starts is available, and only display it if that’s the case. Retitling this ticket accordingly.

dct: you assigned this ticket to you. Does it mean you want to work on it? If so, then I think the first thing to do is to report a wishlist bug in the Tor browser’s Trac, requesting the (second, better) solution described above. Providing a patch would help, I guess ;)

#2 Updated by dct 2014-07-30 11:47:54

I mistakenly assigned it to myself, apologies. I don’t know how to provide the patch. I will try figure out how to report it in Tor browser’s Trac….

#3 Updated by intrigeri 2014-07-30 12:11:55

  • Subject changed from Hide Torbutton "Open Network Settings" menu entry to Hide Torbutton "Open Network Settings" menu entry when the Tor Launcher is not enabled
  • Assignee deleted (dct)

#4 Updated by intrigeri 2014-09-22 11:17:07

  • Type of work changed from Upstream to Code

#5 Updated by intrigeri 2015-01-14 12:32:12

  • Target version set to Tails_1.4

We can now hide this menu entry with an environment variable, so flagging for 1.4.

#6 Updated by anonym 2015-03-31 19:48:12

  • Assignee set to anonym

#7 Updated by anonym 2015-04-01 13:19:17

  • Status changed from Confirmed to In Progress

Applied in changeset commit:bcfece3f71a5ab6fb61a5b7dee93efa1919f30ba.

#8 Updated by anonym 2015-04-17 15:12:03

  • % Done changed from 0 to 40
  • Feature Branch set to feature/9031-tor-browser-4.5

anonym wrote:
> Applied in changeset commit:bcfece3f71a5ab6fb61a5b7dee93efa1919f30ba.

This was made in the feature/9031-tor-browser-4.5 branch.

#9 Updated by anonym 2015-04-17 15:14:07

#10 Updated by anonym 2015-04-29 11:50:26

  • Assignee deleted (anonym)
  • % Done changed from 40 to 50
  • QA Check set to Ready for QA

#11 Updated by intrigeri 2015-05-01 10:00:14

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

Applied in changeset commit:80b906654cb0b40164913fedacefd851b02d64bd.

#12 Updated by BitingBird 2015-05-01 10:12:59

  • QA Check changed from Ready for QA to Pass

#13 Updated by BitingBird 2015-05-12 18:46:00

  • Status changed from Fix committed to Resolved