Feature #7637

Patch greeter.dconf-defaults instead of shipping a full fork

Added by intrigeri 2014-07-21 15:17:05 . Updated 2020-04-15 06:05:37 .

Status:
Resolved
Priority:
High
Assignee:
intrigeri
Category:
Target version:
Tails_2.0
Start date:
2014-07-21
Due date:
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
0
Affected tool:
Welcome Screen
Deliverable for:

Description

Commit 6a2931f introduces a full fork of greeter.gsettings, without any explanation of why it needs to be done this way. This will be hard to maintain, and may cause hard to debug issues. Please convert this back to a chroot_local-patches.

Subtasks

Related issues

Related to Tails - Feature #7599: Update the packaging to get the greeter launched in GDM 3.12 Resolved 2014-07-17

History

#1 Updated by intrigeri 2014-07-21 15:17:50

  • Target version set to Tails_2.0

#2 Updated by alant 2014-07-22 19:50:38

  • Assignee changed from alant to intrigeri
  • QA Check set to Info Needed

I fail to see why a patch is better: the only uncommented parts in this file are shipped by Tails. Please explain why you think we should patch the file.

#3 Updated by alant 2014-07-22 19:54:38

I was wrong, there is also:

[org.gnome.login-screen] logo='/usr/share/icons/gnome/48x48/places/debian-swirl.png' fallback-logo='/usr/share/icons/gnome/48x48/places/debian-swirl.png'

Is that suffisient to want to go the patches way?

#4 Updated by intrigeri 2014-07-22 21:57:36

> I fail to see why a patch is better: the only uncommented parts in this file are
> shipped by Tails.

This won’t necessarily be the case forever. Let’s future-proof it: a patch (that will likely conflict on upgrades) will force us to resolve conflicts that may arise, and decide if we want to take the new upstream stuff, or not. Simply overriding the file allows us to be blind and fully ignore this. This can cause hard to debug problems.

> I was wrong, there is also:
> […]
> Is that suffisient to want to go the patches way?

Definitely, in my opinion. Fully overriding files is fragile, and should be avoided when possible. (And no, I’m not going to work on turning every file we override in /etc into a patch right away, but at least, let’s not make things worse :)

#5 Updated by intrigeri 2014-07-22 21:58:49

  • Assignee changed from intrigeri to alant
  • QA Check deleted (Info Needed)

#6 Updated by intrigeri 2014-07-27 21:38:43

  • related to Feature #7599: Update the packaging to get the greeter launched in GDM 3.12 added

#7 Updated by intrigeri 2014-07-27 21:43:18

  • Subject changed from Patch greeter.gsettings instead of shipping a full fork to Patch greeter.dconf-defaults instead of shipping a full fork
  • Status changed from Confirmed to In Progress
  • Assignee changed from alant to intrigeri

I’m on it, as it’s blocking me for other things I want to do.

#8 Updated by intrigeri 2014-07-27 22:34:29

  • Status changed from In Progress to Resolved

#9 Updated by intrigeri 2014-07-28 10:57:08

  • % Done changed from 0 to 100

#10 Updated by intrigeri 2020-04-15 06:05:37

  • Affected tool changed from Greeter to Welcome Screen