Bug #7525

/usr/local/bin/iceweasel should check if iceweasel is already started before bothering the user

Added by alant 2014-07-09 12:45:08 . Updated 2015-08-11 10:47:43 .

Status:
Resolved
Priority:
Low
Assignee:
Category:
Target version:
Tails_1.5
Start date:
2014-07-09
Due date:
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
1
Affected tool:
Browser
Deliverable for:

Description

To reproduce the issue:

  1. Start torbrowser when tor has not started e.g. by clicking on its panel icon
  2. Get asked if you really want to start tor browser and anwser yes
  3. Have a torbrowser windows displayed
  4. Start tor browser again e.g. by clicking on its panel icon
  5. You get asked again even thougt the browser is already open

Expected result:

  • Not to be asked again when the browser is already launched

Files

skip_tor_dialog.txt (1118 B) hybridwipe, 2015-07-16 21:31:24

Subtasks

History

#1 Updated by intrigeri 2014-07-10 07:30:39

I agree this would be an improvement. However, it’s only about what I see as a corner case: starting the Tor browser twice, while Tor is still not ready. So, IMO that’s low priority.

#2 Updated by BitingBird 2014-07-19 18:18:28

  • Priority changed from Normal to Low

#3 Updated by hybridwipe 2015-07-16 21:28:40

  • File <del>missing: skip_tor_dialog.txt</del> added

Patch attached, please review.

#4 Updated by hybridwipe 2015-07-16 21:29:13

  • File deleted (skip_tor_dialog.txt)

#5 Updated by hybridwipe 2015-07-16 21:31:40

Wrong file before, here’s the patch.

#6 Updated by intrigeri 2015-07-17 01:44:48

  • Target version set to Tails_1.5
  • QA Check set to Ready for QA

#7 Updated by intrigeri 2015-07-17 01:56:31

  • Status changed from Confirmed to In Progress

#8 Updated by intrigeri 2015-07-17 01:57:53

  • Assignee set to intrigeri

#9 Updated by intrigeri 2015-07-17 07:45:02

  • Assignee changed from intrigeri to hybridwipe
  • % Done changed from 0 to 30
  • QA Check changed from Ready for QA to Dev Needed

Thanks! I only have a minor comment wrt. the implementation.

I see if [ $(pgrep -u amnesia -f ${TBB_INSTALL}/firefox) ], and it seems to work, but I don’t understand why we’re capturing pgrep’s stdout and testing that, instead of simply testing its exit code. I would instead write if pgrep -u amnesia -f "${TBB_INSTALL}/firefox" (note the added quoting by the way). Any problem with this suggestion? If none (and once you’ve tested it successfully) I’ll appy your patch + the proposed change on top.

#10 Updated by hybridwipe 2015-07-17 14:58:56

  • Target version deleted (Tails_1.5)

intrigeri wrote:
> Thanks! I only have a minor comment wrt. the implementation.
>
> I see if [ $(pgrep -u amnesia -f ${TBB_INSTALL}/firefox) ], and it seems to work, but I don’t understand why we’re capturing pgrep’s stdout and testing that, instead of simply testing its exit code. I would instead write if pgrep -u amnesia -f "${TBB_INSTALL}/firefox" (note the added quoting by the way). Any problem with this suggestion? If none (and once you’ve tested it successfully) I’ll appy your patch + the proposed change on top.

No particular reason, your version is preferable, thanks for pointing that out.

#11 Updated by intrigeri 2015-07-18 00:53:56

> No particular reason, your version is preferable, thanks for pointing that out.

OK, thanks for the feedback. Could you please test “my” version?

#12 Updated by intrigeri 2015-07-18 00:54:43

  • Target version set to Tails_1.6

(Postponing, assuming that was the intent behind removing the target version. I’d like this to stay on our radar since we’re almost done.)

#13 Updated by hybridwipe 2015-07-18 00:58:12

intrigeri wrote:
> > No particular reason, your version is preferable, thanks for pointing that out.
>
> OK, thanks for the feedback. Could you please test “my” version?

Sorry for the brief comment; I did, it works just as well, please commit and close :)

#14 Updated by intrigeri 2015-07-18 01:54:18

  • Assignee changed from hybridwipe to intrigeri
  • Target version changed from Tails_1.6 to Tails_1.5
  • QA Check changed from Dev Needed to Pass

#15 Updated by intrigeri 2015-07-18 03:14:00

  • Status changed from In Progress to Fix committed
  • % Done changed from 30 to 100

Applied in changeset commit:9c04b12756af5199cba8ed13150d89218f362e09.

#16 Updated by intrigeri 2015-07-18 03:14:39

  • Assignee deleted (intrigeri)

Merged, thanks!

#17 Updated by BitingBird 2015-08-11 10:47:43

  • Status changed from Fix committed to Resolved