Bug #7406

OpenPGP Applet system tray icon should be themable

Added by alant 2014-06-12 06:13:46 . Updated 2017-06-30 15:35:03 .

Status:
Rejected
Priority:
Low
Assignee:
Category:
Camouflage
Target version:
Start date:
2014-06-12
Due date:
% Done:

0%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
OpenPGP Applet
Deliverable for:

Description

make_icon_source should use something like g_themed_icon_new_from_names, e.g. so that Tails’ Windows Camouflage mode can set different icons without resorting to ugly hacks.

Subtasks

Related issues

Related to Tails - Bug #7742: Non-DFSG compliant images in the Tails OpenPGP Applet Resolved 2014-08-04

History

#1 Updated by intrigeri 2014-06-12 11:12:04

Subject: OpenPGP Applet system tray icon should be themable

#2 Updated by intrigeri 2014-06-12 11:12:46

  • Subject changed from gpgApplet should ues a themable systray icon to OpenPGP Applet system tray icon should be themable
  • Status changed from New to Confirmed

#3 Updated by intrigeri 2014-06-12 11:36:08

  • Description updated

#4 Updated by alant 2014-07-05 16:44:23

OpenPGP applet lives in the tails repository at http://git.tails.boum.org/tails/. Most code is in config/chroot_local-includes/usr/local/bin/gpgApplet. One can hack live on /usr/local/bin/gpgApplet and pkill -f gpgAplet then gpgApplet.

#5 Updated by nodens 2014-08-02 01:07:43

The code currently lives at https://git-tails.immerda.ch/nodens/openpgp-applet/. Work should be done in the master branch first. Updating the upstream metadata (dependencies in Makefile.PL, etc.) would be appreciated. Testing on Wheezy and current Debian unstable is important.

#6 Updated by nodens 2014-08-02 01:10:11

  • related to Feature #6507: Package our OpenPGP applet for Debian and maintain it there added

#7 Updated by nodens 2014-08-04 11:07:29

  • related to Bug #7742: Non-DFSG compliant images in the Tails OpenPGP Applet added

#8 Updated by nodens 2014-08-04 11:14:26

  • related to deleted (Feature #6507: Package our OpenPGP applet for Debian and maintain it there)

#9 Updated by nodens 2015-01-01 11:17:46

Hi, a few thoughts about this.

Since icons for Tails OpenPGP Applet live in /usr/share/perl5/auto/share/dist/OpenPGP_Applet/ now since File::ShareDir is used (at least in my repo), it’s not that easy to make them themables. I’m reluctant to go back to /usr/share paths only since it makes things more difficult for distribution as a standalone project.

What could probably be done is modifying the icon search code to check for icons in the proper theme path before falling back to the embedded ones. The packaging (debian or otherwise) can move the icons to the proper /usr/share path.

#10 Updated by nodens 2015-01-01 11:18:11

  • related to Feature #6507: Package our OpenPGP applet for Debian and maintain it there added

#11 Updated by intrigeri 2015-01-01 13:14:16

> What could probably be done is modifying the icon search code to check for icons in the proper theme path before falling back to the embedded ones.

ACK.

#12 Updated by BitingBird 2015-01-04 17:40:22

  • Affected tool set to OpenPGP Applet

#13 Updated by BitingBird 2015-01-07 17:34:19

  • Category set to Camouflage

#14 Updated by nodens 2015-08-18 12:21:00

  • related to deleted (Feature #6507: Package our OpenPGP applet for Debian and maintain it there)

#15 Updated by Anonymous 2017-06-30 15:22:27

  • Priority changed from Normal to Low
  • Starter deleted (Yes)

I’m setting this low priority as the cost benefit ratio seems very low from my POV.

#16 Updated by intrigeri 2017-06-30 15:35:03

  • Status changed from Confirmed to Rejected

Rejecting as we have no Camouflage mode anymore.