Bug #7365

Report bugs spotted by window-picker-applet audit upstream

Added by alant 2014-06-03 03:24:32 . Updated 2014-09-23 04:39:15 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Camouflage
Target version:
Start date:
2014-06-03
Due date:
% Done:

100%

Feature Branch:
Type of work:
Communicate
Blueprint:

Starter:
0
Affected tool:
Deliverable for:

Description

Two C experts read the code and spotted a few bugs.

They should be solved by the attached patches which should now be tested and reported upstream.

Files

0001-Fix-about-dialog-logo-leak.patch (887 B) alant, 2014-06-03 03:24:23
0002-Fix-configuration-options-not-properly-marked-as-tra.patch (2509 B) alant, 2014-06-03 03:24:23
0004-Avoid-GTK-namespace-pollution.patch (1352 B) alant, 2014-06-03 03:24:23
0005-Speed-up-some-private-data-access.patch (2481 B) alant, 2014-06-03 03:24:24
0006-Don-t-leak-task-title-text-attributes.patch (825 B) alant, 2014-06-03 03:24:24
0007-Use-proper-event-time-when-closing-a-window-in-respo.patch (801 B) alant, 2014-06-03 03:24:25
0003-Fix-improper-pixbuf-lifetime-handling.patch (2186 B) alant, 2014-09-13 15:12:56

Subtasks

Related issues

Related to Tails - Feature #7349: Package window-picker-applet Rejected 2014-05-31

History

#1 Updated by intrigeri 2014-06-03 04:15:57

> Two C experts read the code and spotted a few bugs.

Congrats to you, for having them look at the code, and to them, for finding these bugs!

#2 Updated by intrigeri 2014-07-19 17:20:09

It would be great to have these bugs fixed upstream while the code hasn’t moved too much there… and while our memories are fresh wrt. the suggested improvements. Also, given we’re in the process of packaging window-picker-applet for Debian, it would be great if these bugs were fixed before we upload the package.

#3 Updated by intrigeri 2014-07-19 17:20:44

#4 Updated by intrigeri 2014-07-19 17:21:14

  • Subject changed from Report bugs spotted by window-picker-applet audit upstream. to Report bugs spotted by window-picker-applet audit upstream
  • Category set to Camouflage
  • Priority changed from Normal to Elevated

#5 Updated by alant 2014-09-13 15:12:09

  • File deleted (0003-Fix-improper-pixbuf-lifetime-handling.patch)

#7 Updated by alant 2014-09-13 15:13:15

  • File deleted (0008-MAYBE-Simplify-named-icon-display.patch)

#8 Updated by alant 2014-09-13 15:33:52

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 20

Patches were refined and sent upstream. Waiting for their answer.

#9 Updated by intrigeri 2014-09-22 11:18:38

  • Type of work changed from Upstream to Communicate

#10 Updated by alant 2014-09-23 04:39:15

  • Status changed from In Progress to Resolved
  • Assignee deleted (alant)
  • % Done changed from 20 to 100

Patches are meged upstream (https://github.com/lanoxx/window-picker-applet/commit/a7e725b7ffa2c6ac8bd5359177ef52c39e35ce19 and followups).