Feature #7358

Remove the VirtualBox warning while shutting down

Added by sajolida 2014-06-01 09:45:08 . Updated 2016-02-09 15:48:57 .

Status:
Rejected
Priority:
Normal
Assignee:
Category:
Virtualization
Target version:
Start date:
2014-06-01
Due date:
% Done:

0%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
1
Affected tool:
Deliverable for:

Description

While shutting down and stopping services, the one related to VirtualBox Additions appears as [WARNING!] when not running inside VirtualBox.

The error message is:

VirtualBox Additions disabled, not in a Virtual Machine. [WARNING!]

Some user have reported to be worried about that warning.

Implementation hints

This problem is twofold:

  • detecting if we’re running inside VirtualBox (there is virt-what in Tails, that we’re using for similar needs)
  • and if that’s not the case, making it so the virtualbox*
    initscripts are not run at shutdown/reboot time (that’s a job for
    update-rc.d).

The entire thing could be run via an initscript started
late in the boot process, e.g. after GDM.


Files


Subtasks


Related issues

Related to Tails - Bug #8082: Remove the PulseAudio initscript's warning Resolved 2014-10-12

History

#1 Updated by sajolida 2014-06-02 00:58:43

  • Description updated
  • Starter changed from No to Yes

#2 Updated by sajolida 2014-06-02 00:59:01

  • Description updated

#3 Updated by emmapeel 2014-08-19 11:41:10

Another user reports fear reading a similar message in Whisperback, ‘orange error no VMware (which is true)’:

Message-Id: GxJM0zz3xvh2XFlClFUDqjZ0XZE2kZcz@tails-bugs.boum.org-schleuder

Along with another warning:

Pulseaudio configured for per-user-session

This shouldn’t be warnings. Shall I report it to Debian?

(I can reproduce the pulseaudio error, but instead of VMWare I get:

Virtualbox additions disabled, not in a Virtual Machine

like previously reported.

#4 Updated by intrigeri 2014-08-19 12:00:23

redmine@labs.riseup.net wrote (19 Aug 2014 11:41:10 GMT) :
> This shouldn’t be warnings. Shall I report it to Debian?

I agree these shouldn’t be warnings in the context of Tails, but it’s different in the more general case of Debian, where installing a package that provides a service generally means one wants to use it, and then if it fails to start for some reason, it makes sense to warn the user. Note that in the case of PulseAudio, 5.0-3 (in Jessie) removes the initscript entirely, so case closed.

#5 Updated by intrigeri 2014-10-13 01:49:55

  • related to Bug #8082: Remove the PulseAudio initscript's warning added

#6 Updated by sajolida 2014-11-16 11:19:50

  • Category set to Virtualization

#7 Updated by hybridwipe 2015-08-09 22:59:32

  • File <del>missing: vbox_disable.txt</del> added
  • Assignee set to hybridwipe

Is it really important that the service runs when in Virtualbox? I.e., why not just disable stopping the service for all cases, as we do for some other services? See also Feature #6463.

If that’s acceptable, patch is attached. Otherwise I can implement it as originally proposed, using virt-what / systemd-detect-virt.

#8 Updated by hybridwipe 2015-08-09 23:00:05

  • File deleted (vbox_disable.txt)

#9 Updated by hybridwipe 2015-08-09 23:03:11

Ooops, wrong file. Here.

#10 Updated by intrigeri 2015-08-18 05:41:55

  • Target version set to Tails_1.7
  • QA Check set to Ready for QA

#11 Updated by BitingBird 2015-09-22 15:37:41

  • Status changed from Confirmed to In Progress
  • Assignee deleted (hybridwipe)
  • % Done changed from 0 to 20

Removing assignee because you want other people’s input on that :)

#12 Updated by intrigeri 2015-12-14 09:51:15

  • Assignee set to anonym
  • Target version changed from Tails_1.7 to Tails_2.0

Explicitly putting on the RM’s plate, because apparently Ready for QA wasn’t enough.

#13 Updated by anonym 2016-01-27 14:36:48

  • Target version changed from Tails_2.0 to Tails_2.2

#14 Updated by anonym 2016-02-09 15:48:57

  • Status changed from In Progress to Rejected
  • Assignee deleted (anonym)
  • % Done changed from 20 to 0
  • QA Check deleted (Ready for QA)

I actually applied the patch and built an image, but then I realized that once we moved to Jessie, we have a plymouth splash screen that hides the warning message in question. So since there’s no visible problem any more, let’s not carry a delta against Debian, and let’s hope someone cares enough to fix the upstream init script.