Bug #7282
Tor Launcher: Don't relabel finish button when not owning Tor.
10%
Description
Commit e7fd8a8 in our Tor Launcher Git repo is part of our delta against upstream.
It changes the the label of the final button which applies Tor Launcher’s settings to Tor and exits to “Finnish” instead of upstream’s “Connect”. I cannot remember why we wanted this in the first place, and imho “Connect” seems fine — it actually makes it more clear what’s going on compared to the more generic “Finnish”. Also, on the start page of Tor Launcher, the button is still labelled “Connect”.
Can we drop this?
Subtasks
Related issues
|
Related to Tails - |
Resolved | 2014-07-19 |
History
#1 Updated by anonym 2014-05-26 06:14:08
- Assignee set to sajolida
Assigning to you, sajolida, in hope of a quick resolution of the Discuss part, since I think you were the one requesting the Connect -> Finnish change.
#2 Updated by intrigeri 2014-06-10 10:51:08
- QA Check set to Info Needed
#3 Updated by intrigeri 2014-06-11 12:59:51
- % Done changed from 0 to 10
June 2014 meeting: We agreed that “Connect” is fine, and didn’t see what good “Finish” does. sajolida?
#4 Updated by sajolida 2014-06-19 13:10:14
- Assignee changed from sajolida to anonym
- QA Check changed from Info Needed to Dev Needed
- Type of work changed from Discuss to Code
Having a quick look at the code and the Tor Launcher interface, I agree that there is not point in diverging from upstream. I don’t remember why we put Finish in the first place…
#5 Updated by intrigeri 2014-07-19 19:13:22
- Status changed from Confirmed to Rejected
#6 Updated by intrigeri 2014-07-19 19:15:28
Accordingly created Feature #7620.
#7 Updated by intrigeri 2014-07-19 19:15:38
- related to
Feature #7620: Drop Tor Launcher patch that relabels the finish button added
#8 Updated by BitingBird 2014-07-22 22:44:27
- Target version deleted (
Hole in the Roof)