Bug #7097
Tor browser always displays the upgrade notification with Torbutton >= 1.6.8.0
100%
Description
In our Tor browser builds, the pref torbrowser.version
is set to Tails
, and this does not work well together with upstream’s commit b9fb03cd
(in Torbutton’s Git repo).
My guess is that there’s an assumption that torbrowser.version
must look like an actual TBB version, like 3.5.4-Linux
or whatever. With it set to something like Tails
the upgrade notification is always blinking, suggesting that there’s an upgrade available.
Is this an upstream bug, or do we have to set torbrowser.version
to something else from now on?
Subtasks
History
#1 Updated by anonym 2014-04-16 02:00:16
- Category set to 176
- Type of work changed from Upstream to Research
Also note that this bug will block us from upgrading Torbutton beyond 1.6.7.0. As of Tails 0.23 we’re on 1.6.6.0, and we’ll likely stay on that version for Tails 1.0 as well.
#2 Updated by intrigeri 2014-04-16 16:54:56
- Status changed from New to Confirmed
- Assignee set to anonym
- Target version set to Tails_1.1
- QA Check set to Info Needed
My reading of this commit makes me think that we could simply set extensions.torbutton.lastBrowserVersion
to the same value as torbrowser.version
, and be done with it. anonym, what do you think?
(Of course, feel free to assign this ticket to nobody once you’ve replied. OTOH, since you’ll be the RM for 1.1, and will have to deal with the Torbutton upgrade, likely you’ll be the one dealing with this issue, so…)
#3 Updated by anonym 2014-04-16 22:18:27
- QA Check deleted (
Info Needed) - Type of work changed from Research to Code
intrigeri wrote:
> My reading of this commit makes me think that we could simply set extensions.torbutton.lastBrowserVersion
to the same value as torbrowser.version
, and be done with it. anonym, what do you think?
True, that must work. I’ll fix it => assigned to me for 1.1.
#4 Updated by intrigeri 2014-05-02 17:42:00
- Subject changed from Our Tor browser always show the upgrade notification with Torbutton >= 1.6.8.0 to Tor browser always displays the upgrade notification with Torbutton >= 1.6.8.0
#5 Updated by intrigeri 2014-05-25 14:45:05
- Assignee changed from anonym to intrigeri
- % Done changed from 0 to 20
- QA Check set to Ready for QA
- Feature Branch set to feature/torbutton-1.6.9.0
#6 Updated by intrigeri 2014-05-25 14:46:05
- Status changed from Confirmed to In Progress
#7 Updated by intrigeri 2014-05-26 02:10:13
- Status changed from In Progress to Fix committed
- Assignee deleted (
intrigeri) - % Done changed from 20 to 100
- QA Check changed from Ready for QA to Pass
#8 Updated by BitingBird 2014-07-22 23:07:33
- Status changed from Fix committed to Resolved