Feature #7087

Do not bundle Tor Launcher in the main Tails Git repository

Added by intrigeri 2014-04-15 10:39:26 . Updated 2015-05-12 18:46:37 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Tor configuration
Target version:
Start date:
2014-04-15
Due date:
% Done:

100%

Feature Branch:
feature/8925-tor-0.2.6
Type of work:
Code
Blueprint:

Starter:
0
Affected tool:
Tor Launcher
Deliverable for:

Description

Back when bridges support was merged at the last minute for 0.23, it was considered acceptable on the short term to simply add a copy of the Tor Launcher into the main Tails repository. This was supposed to be a short-term hack that we will get rid of soon, hence this ticket so that it’s not forgotten.

For the record, bundling Tor Launcher in the main Tails repository has the following problems:

  • it bloats the repo a bit (we could probably live with that)
  • it makes reviewing painful: one has to review changes in our Tor Launcher repo first, and then compare with the copy that was pushed into the main repo
  • I could not find any documentation about how to actually do the copy (not sure it’s a trivial copy, or if one needs to run some kind of make command first)

There are several ways we could fix this:

  1. build a Debian package for Tor Launcher
  2. use a Git submodule

I (intrigeri) am not convinced a .deb would be the best way to integrate Tor Launcher into Tails, and doing so adds quite some painful, repetitive work to the release process. So perhaps a submodule would be better, assuming our build system (including Jenkins setup, Vagrant) supports it, and assuming it can be documented so that every contributor can understand how the whole thing works.


Subtasks


Related issues

Related to Tails - Feature #7036: Move custom software to our main Git repository In Progress
Related to Tails - Bug #7283: Use upstream solution for Tor Launcher: Set ClientTransportPlugin according to the bridge entries Resolved 2014-05-26
Related to Tails - Feature #7620: Drop Tor Launcher patch that relabels the finish button Resolved 2014-07-19
Blocked by Tails - Feature #7934: Upgrade to Tor 0.2.6.x Resolved 2014-09-22

History

#1 Updated by intrigeri 2014-05-26 02:43:37

  • related to Feature #7036: Move custom software to our main Git repository added

#2 Updated by intrigeri 2014-06-10 10:56:10

  • Category set to Tor configuration

#3 Updated by intrigeri 2014-06-10 10:56:52

#4 Updated by sajolida 2014-07-10 15:06:23

  • Target version set to Sustainability_M1

Tails 2.0 if the solution is cheap.

#5 Updated by BitingBird 2015-01-07 16:30:43

  • Affected tool set to Tor Launcher

#6 Updated by intrigeri 2015-03-16 10:27:01

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 10
  • Feature Branch set to feature/8925-tor-0.2.6

feature/8925-tor-0.2.6 replaces the bundled Tor Launcher with the one that’s shipped with Tor Browser.

#7 Updated by intrigeri 2015-03-16 10:30:27

Applied in changeset commit:2a217fc6f4c5fbddc1b3cb12a83eede3a8dc1162.

#8 Updated by intrigeri 2015-03-16 10:30:35

  • related to Bug #7283: Use upstream solution for Tor Launcher: Set ClientTransportPlugin according to the bridge entries added

#9 Updated by intrigeri 2015-03-16 10:33:58

  • Target version changed from Sustainability_M1 to Tails_1.4

Flagging for 1.4, since that’s most likely the release that’ll have Tor 0.2.6. Making progress on the 2.0 milestone, woohoo!

#10 Updated by intrigeri 2015-03-17 11:11:07

Applied in changeset commit:32d31150494393a19cd66b4c5d6ed4c69f3dfc48.

#11 Updated by intrigeri 2015-04-11 10:01:08

  • related to Feature #7620: Drop Tor Launcher patch that relabels the finish button added

#12 Updated by anonym 2015-04-29 11:45:10

  • Assignee deleted (anonym)
  • % Done changed from 10 to 50
  • QA Check set to Ready for QA

#13 Updated by anonym 2015-04-29 11:46:05

#14 Updated by intrigeri 2015-05-01 10:00:12

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

Applied in changeset commit:e88f3b27b295e745eb31af186fc48879bc4a1ca0.

#15 Updated by BitingBird 2015-05-01 10:13:33

  • QA Check changed from Ready for QA to Pass

#16 Updated by BitingBird 2015-05-12 18:46:37

  • Status changed from Fix committed to Resolved