Bug #6997

CSS of the sidebar prevents "Download Tails" from being translated into German

Added by intrigeri 2014-03-30 18:10:31 . Updated 2014-04-04 09:23:42 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Internationalization
Target version:
Start date:
2014-03-30
Due date:
% Done:

50%

Feature Branch:
Type of work:
Website
Blueprint:

Starter:
1
Affected tool:
Deliverable for:

Description

In German, “Download Tails” would be translated “Tails herunterladen” (I think).

I’ve tried moving the span with the “download” class after the one with the “tails” class, in the German translated string (in sidebar.de.po), but the result is ugly, due to spacing added to these elements, and assuming they are always displayed in the same order.

A CSS expert could presumably save the day.

The HTML code lives in https://git-tails.immerda.ch/tails/tree/wiki/src/sidebar.mdwn, and the CSS in https://git-tails.immerda.ch/tails/tree/wiki/src/local.css.

Subtasks

History

#1 Updated by intrigeri 2014-03-30 18:10:51

  • Starter changed from No to Yes

#2 Updated by Anonymous 2014-03-30 18:38:56

  • Assignee deleted (None)

#3 Updated by Anonymous 2014-03-30 20:37:05

  • Status changed from Confirmed to Fix committed
  • Assignee set to intrigeri
  • % Done changed from 0 to 90

please test & pull commit f1cf7cefe62729c7a77cd2e9cb54a1e57cb24363

#4 Updated by intrigeri 2014-03-30 21:17:40

  • Status changed from Fix committed to In Progress
  • Assignee changed from intrigeri to sajolida
  • % Done changed from 90 to 50
  • QA Check set to Ready for QA

Thanks!

I’m reassigning this ticket to sajolida for review, and marking as “ready for QA” (which means: ready to be reviewed, and hopefully merged).

Note that “Fix committed” means “fix committed in the branch used for the next release”, rather than “there is a proposed fix somewhere” :)

I’m also setting progress back to 50%, to leave room for future round trips, if needed.

Hoping this clarifies how we’re using Redmine, and makes things smoother for everybody in the future! :)

#5 Updated by intrigeri 2014-03-30 21:18:14

sajolida: u’s repository is 451f/tails, at the usual place.

#6 Updated by Anonymous 2014-03-30 22:01:53

thanks for the comments :)

i just retested this in Tor Browser and saw that box-sizing is still to be used with the proprietary prefix there. Recommitted a second update : master 6cc0969

#7 Updated by sajolida 2014-04-02 17:18:11

  • Status changed from In Progress to Resolved
  • Assignee deleted (sajolida)
  • QA Check changed from Ready for QA to Pass

That for the patch u. I tested it with the German order and it works, so I merged your branch and improved a bit the line height with commit f9e2487.

#8 Updated by Anonymous 2014-04-03 22:16:36

thanks, sajolida!

#9 Updated by intrigeri 2014-04-04 09:23:42

sajolida wrote:
> That for the patch u. I tested it with the German order and it works, so I merged your branch and improved a bit the line height with commit f9e2487.

You apparently did not merge u’s branch, only the changes it carries. Her changes are mixed with an “updated PO files” commit (9565bb2e61c52148c6c4ec82968149d0dcab87c8). Anyway, I’m going to merge the relevant (now no-op) commits as part of a translation pull request right now.