Bug #6885

Picking a non-English locale breaks bridge mode

Added by anonym 2014-03-07 19:44:53 . Updated 2018-04-08 16:47:24 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Target version:
Start date:
2014-03-07
Due date:
% Done:

100%

Feature Branch:
bugfix/6885-tor-launcher-localisation
Type of work:
Research
Blueprint:

Starter:
0
Affected tool:
Deliverable for:

Description

Just test by selecting (seemingly) any non-English language in Tails Greeter.


Subtasks


History

#1 Updated by intrigeri 2014-03-07 19:56:51

  • Subject changed from Picking a non-English locale breaks bridge mode. to Picking a non-English locale breaks bridge mode
  • Parent task set to Feature #5920

#2 Updated by intrigeri 2014-03-11 10:08:01

That’s apparently a known issue upstream.

#3 Updated by anonym 2014-03-12 22:54:23

  • Status changed from Confirmed to In Progress
  • Assignee changed from anonym to intrigeri
  • % Done changed from 0 to 80
  • QA Check set to Ready for QA
  • Feature Branch set to bugfix/6885-tor-launcher-localisation

I’ve pushed a fix in the bugfix/6885-tor-launcher-localisation Tails Git branch but since the fix is confined to Tor Launcher, also see our Tor Launcher repo. My tests are positive for all locales I tested it on: English (default), Chinese and German (translated), Bosnian and Turkish (not translated, so should fallback to English).

The short story is that XUL translation is pretty fragile and easily results in fatal errors like this for out-dated translations.

The long story can be read here, where I also go into some detail for an upstream fix.

#4 Updated by intrigeri 2014-03-14 18:27:24

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)
  • % Done changed from 80 to 100

Merged, after one more code/review cycle.

#5 Updated by anonym 2014-03-19 07:23:43

  • Status changed from Fix committed to Resolved

#6 Updated by intrigeri 2018-04-08 16:47:24

  • QA Check deleted (Ready for QA)