Bug #6806

WhisperBack test suite for log sanitization does not test what it should

Added by intrigeri 2014-03-02 11:05:33 . Updated 2014-07-22 23:01:49 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Start date:
2014-03-02
Due date:
% Done:

100%

Feature Branch:
whisperback:bugfix/filter_more_serial_nos
Type of work:
Code
Blueprint:

Starter:
0
Affected tool:
WhisperBack
Deliverable for:

Description

It’s testing that [$something REMOVED] can be found after sanitizing, but it does not test that the info that should be removed cannot be found anymore, which is what we should really test.


Subtasks


Related issues

Blocks Tails - Bug #6798: Whisperback should sanitize more serial numbers Resolved 2014-03-01
Blocks Tails - Bug #6797: Whisperback should sanitize DMI Resolved 2014-03-01
Blocks Tails - Bug #6804: Sanitize expanded IPv6 addresses in WhisperBack Resolved 2014-03-02

History

#1 Updated by alant 2014-03-02 12:37:59

  • Status changed from Confirmed to In Progress
  • QA Check set to Ready for QA
  • Feature Branch set to whisperback:bugfix/filter_more_serial_nos

This is now implemented in the feature branch.

#2 Updated by intrigeri 2014-03-04 12:36:49

  • Target version set to Tails_0.23

#3 Updated by intrigeri 2014-03-04 12:38:20

  • Assignee changed from alant to intrigeri

I’ll give anonym a hand on that one.

#4 Updated by intrigeri 2014-03-04 14:48:01

  • Assignee changed from intrigeri to alant
  • QA Check changed from Ready for QA to Dev Needed

I’ve documented how to run the test suite in that branch.

The test suite does not pass for me.

#5 Updated by intrigeri 2014-03-06 11:41:05

  • Target version deleted (Tails_0.23)

#6 Updated by alant 2014-03-10 12:34:38

  • Assignee deleted (alant)
  • % Done changed from 0 to 50
  • QA Check changed from Dev Needed to Ready for QA

Marked the test expected to failed as such.

#7 Updated by alant 2014-03-10 18:55:44

  • Assignee set to anonym

#8 Updated by anonym 2014-05-15 03:17:14

  • Status changed from In Progress to Fix committed
  • Assignee deleted (anonym)
  • QA Check changed from Ready for QA to Pass

#9 Updated by intrigeri 2014-05-26 02:44:13

  • Target version set to Tails_1.1
  • % Done changed from 50 to 100

#10 Updated by BitingBird 2014-07-22 23:01:50

  • Status changed from Fix committed to Resolved