Feature #6577

Convert existing Tails devices to UEFI on full upgrade

Added by intrigeri 2014-01-07 14:46:20 . Updated 2014-07-22 23:00:54 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Installation
Target version:
Start date:
2014-01-07
Due date:
% Done:

100%

Feature Branch:
installer:feature/6577-convert-to-UEFI
Type of work:
Code
Blueprint:

Starter:
1
Affected tool:
Deliverable for:

Description

When upgrading an existing Tails device with Tails Installer, turn the system partition into an ESP, just like we already do (at least in liveusb-creator 3.11.6+tails1-3 and later) on initial installation.

Relevant code lines that one can get inspiration from:

partition_type = 'C12A7328-F81F-11D2-BA4B-00A0C93EC93B' 
self._set_partition_flags(1, SYSTEM_PARTITION_FLAGS)

Subtasks


History

#1 Updated by intrigeri 2014-05-13 02:50:18

  • Assignee set to intrigeri

I’m assigning this to myself, but anyone interested, don’t hesitate stealing it if you want to work on this and get it ready by May 23.

#2 Updated by intrigeri 2014-05-13 08:42:35

  • Target version changed from Sustainability_M1 to Tails_1.1

#3 Updated by intrigeri 2014-05-25 12:51:04

  • Description updated

#4 Updated by intrigeri 2014-05-25 14:27:32

  • % Done changed from 0 to 10
  • Feature Branch changed from feature/uefi to installer:feature/6577-convert-to-UEFI

Initial untested implementation pushed. Beware, history can be rewritten.

#5 Updated by intrigeri 2014-05-26 01:32:44

  • Assignee changed from intrigeri to anonym
  • % Done changed from 10 to 30
  • QA Check set to Ready for QA

#6 Updated by intrigeri 2014-05-26 01:40:21

Note that I have not prepared a branch in our main Git repo, nor a snapshot .deb. Given how close the freeze is, this seemed to be too much overhead to me.

So, anonym, please:

  1. review
  2. test by applying the Installer’s master..feature/6577-convert-to-UEFI diff in a running build from devel: an upgraded USB stick’s system partition should have type “EFI System Partition”
  3. merge into the Installer’s master branch
  4. release a new Installer .deb (if ENOTIME, an option might be to skip that part, and postpone to when you’ll build the .deb for 1.1~rc1)

#7 Updated by intrigeri 2014-05-26 02:13:46

  • Status changed from Confirmed to In Progress

#8 Updated by anonym 2014-05-28 10:36:37

  • Status changed from In Progress to Fix committed
  • Assignee deleted (anonym)
  • % Done changed from 30 to 100
  • QA Check changed from Ready for QA to Pass

intrigeri wrote:
> Note that I have not prepared a branch in our main Git repo, nor a snapshot .deb. Given how close the freeze is, this seemed to be too much overhead to me.
>
> So, anonym, please:
>
> # review

Looked good. Nice with some code cleanup too! :)

> # test by applying the Installer’s master..feature/6577-convert-to-UEFI diff in a running build from devel: an upgraded USB stick’s system partition should have type “EFI System Partition”

Worked fine, and the resulting installation also boots.

> # merge into the Installer’s master branch
> # release a new Installer .deb (if ENOTIME, an option might be to skip that part, and postpone to when you’ll build the .deb for 1.1~rc1)

This is now part of liveusb-creator 3.11.6+tails1-4, uploaded to devel’s APT suite.

#9 Updated by BitingBird 2014-07-22 23:00:54

  • Status changed from Fix committed to Resolved