Feature #6486
Make Whisperback .desktop-file translatable in Transifex
100%
Description
Currently one cannot translate “data/whisperback.desktop” through Transifex.
This should be fixed by using intltool during the build process.
Files
Subtasks
Related issues
Related to Tails - |
Resolved | 2013-12-11 | |
Related to Tails - Feature #6488: Make Tails Installer's .desktop-file translatable in Transifex | Confirmed | 2013-12-11 |
History
#1 Updated by intrigeri 2013-12-12 02:47:54
- Category set to Internationalization
- Feature Branch set to WhisperBack:feature/intltoolize
- Starter changed from No to Yes
It already use
intltool a bit (via build_i18n
), so it may not be that hard. I’ve pushed a feature/intltoolize
branch for WhisperBack to start
with, that currently only intltoolize’s the .desktop. Left to do is
integration with intltool-update and intltool-merge. We’re already
missing the former for the Git-using languages anyway (unless I’m
mistaken, we have no documented step anywhere to merge the updated
.pot into these languages’ .po). It might be that
switching to @DistUtilsExtra.auto% would do the job for free; see e.g.
https://bazaar.launchpad.net/~ubuntu-branches/ubuntu/trusty/indicator-weather/trusty/files,
that apparently i18n’izes its .desktop.in this way.
#2 Updated by intrigeri 2014-06-21 14:14:36
- Subject changed from Make Whisperback .desktop-file translatable to Make Whisperback .desktop-file translatable in Transifex
#3 Updated by BitingBird 2015-01-02 18:33:29
- Status changed from Confirmed to In Progress
- % Done changed from 0 to 10
#4 Updated by BitingBird 2015-01-07 18:00:01
- Affected tool set to WhisperBack
#5 Updated by sascha.markus@gmail.com 2018-06-05 21:47:21
- Assignee set to sascha.markus@gmail.com
#6 Updated by Anonymous 2018-08-19 08:27:14
- related to
Feature #6487: Make persistence-setup's .desktop-files translatable in Transifex added
#7 Updated by Anonymous 2018-08-19 08:27:21
- related to Feature #6488: Make Tails Installer's .desktop-file translatable in Transifex added
#8 Updated by sascha.markus@gmail.com 2019-04-23 22:32:32
- Feature Branch changed from WhisperBack:feature/intltoolize to https://gitlab.com/saschamarkus/whisperback/commits/feature/6486-Make-Whisperback-desktop-file-translatable
#9 Updated by sascha.markus@gmail.com 2019-04-23 22:48:26
- Assignee changed from sascha.markus@gmail.com to intrigeri
- QA Check set to Info Needed
Hi @intrigeri
I implemented this feature and tested it in tails.
I build, added a translation in de.po, installed and after a gnome restart I saw the translated name and was able to find it in the launcher using the translated keywords.
Is there anything else to do in Transifex for this ticket?
Should whisperback.pot and/or de.po also be in the commit?
Cheers
Sascha
#10 Updated by intrigeri 2019-04-26 11:32:45
- Assignee changed from intrigeri to sascha.markus@gmail.com
- QA Check changed from Info Needed to Dev Needed
Hi sascha.markus\
gmail.com!
> I implemented this feature and tested it in tails.
Great!
> Is there anything else to do in Transifex for this ticket?
I don’t think so: as long as the strings end up in the POT file we’re good.
> Should whisperback.pot and/or de.po also be in the commit?
In any case, not in the same commit. You can update the POT file, otherwise I’ll update it while releasing a new WhisperBack version. Regarding the PO file, yes so I can easily test this, but Transifex ignores translations done in our Git repos, so eventually your translation will be lost/overridden.
#11 Updated by sascha.markus@gmail.com 2019-04-27 14:53:04
- File 0001-Feature-Make-Whisperback-desktop-file-translatable-r.patch added
- File 0002-Test-translation-for-German-desktop-refs-6486.patch added
- File Screenshot_6486_applications.jpg added
- File Screenshot_6486_translated_keyword.jpg added
- Assignee changed from sascha.markus@gmail.com to intrigeri
- QA Check changed from Dev Needed to Ready for QA
- Feature Branch changed from https://gitlab.com/saschamarkus/whisperback/commits/feature/6486-Make-Whisperback-desktop-file-translatable to https://gitlab.com/saschamarkus/whisperback/tree/feature/6486-Make-Whisperback-desktop-file-translatable-in-Transifex
The implementation is available in the feature branch inmy gitlab repo and as patch 0001-Feature-Make-Whisperback-desktop-file-translatable-r.patch
Also attached is a patch with a generated whisperback.pot file, translations into german in de.po. With this de.po file the whiperback.desktop file was generated.
After executing sudo ./setup.py install i refreshed my running gnome session with ALT-F2 -> restart.
The translated name was displayed and using a translated keyword in the launcher also worked.
#12 Updated by intrigeri 2019-04-29 10:01:45
- Feature Branch changed from https://gitlab.com/saschamarkus/whisperback/tree/feature/6486-Make-Whisperback-desktop-file-translatable-in-Transifex to feature/6486-Make-Whisperback-desktop-file-translatable-in-Transifex, https://gitlab.com/saschamarkus/whisperback/tree/feature/6486-Make-Whisperback-desktop-file-translatable-in-Transifex
Thank you. This will require a test suite update so I’ll release a new WhisperBack, will upload to a dedicated APT suite, and update the test suite accordingly.
#13 Updated by intrigeri 2019-04-29 10:28:35
Released 1.7.23 with these changes. Actually, I think I was wrong: no test suite update will be required. Building, will then run the relevant test suite scenario(s) and merge into stable if happy :)
#14 Updated by intrigeri 2019-04-29 10:32:50
- Target version set to Tails_3.14
#15 Updated by intrigeri 2019-04-29 11:20:57
- Status changed from In Progress to Fix committed
- % Done changed from 10 to 100
Applied in changeset commit:tails|c87a7a1e3203ab885196a542b2b96ea9d25112f8.
#16 Updated by intrigeri 2019-04-29 11:21:43
- Assignee deleted (
intrigeri) - QA Check changed from Ready for QA to Pass
Merged, thanks!
#17 Updated by intrigeri 2019-05-05 08:23:50
- Target version changed from Tails_3.14 to Tails_3.13.2
#18 Updated by anonym 2019-05-06 15:00:57
- Status changed from Fix committed to Resolved
#19 Updated by anonym 2019-05-06 15:03:10
- Target version changed from Tails_3.13.2 to Tails_3.14
#20 Updated by intrigeri 2019-05-06 18:15:33
- Target version changed from Tails_3.14 to Tails_3.13.2