Feature #5938

liveusb-creator should prevent GNOME from managing the target device

Added by Tails 2013-07-18 07:48:23 . Updated 2015-03-15 19:24:45 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Installation
Target version:
Tails_2.0
Start date:
Due date:
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
0
Affected tool:
Installer
Deliverable for:

Description

liveusb-creator should probably inhibit udisks while working, e.g. to avoid spurious GNOME dialogs to appear and tell the user they can unplug their USB stick.

Subtasks

Related issues

Related to Tails - Bug #8331: Merge liveusb-creator upstream changes Rejected 2014-11-28
Related to Tails - Feature #9280: Jessie: Ensure that the persistent volume is not managed by GNOME while it's being created Resolved 2015-04-26 2015-10-15

History

#1 Updated by intrigeri 2013-07-19 09:03:26

  • Starter set to Yes

#2 Updated by intrigeri 2013-10-04 01:24:23

  • Category set to Installation

#3 Updated by jvoisin 2013-10-13 09:33:31

Shouldn’t this be applied upstream ?

#4 Updated by intrigeri 2013-10-14 00:50:36

> Shouldn’t this be applied upstream ?

Actually, our own liveusb-creator is more of a full-blown fork than
a small delta for which we’ve been pushing improvements upstream.
Mostly because (almost?) all the changes we’ve made so far are very
specific to Tails.

But yeah, I agree, this specific change should be upstream’d.
One has to implement it first, obviously :)

#5 Updated by BitingBird 2014-06-09 10:15:45

  • Subject changed from liveusb-creator should inhibit udisks to Liveusb-creator should inhibit udisks

#6 Updated by BitingBird 2014-06-09 15:29:42

  • Subject changed from Liveusb-creator should inhibit udisks to liveusb-creator should inhibit udisks

#7 Updated by BitingBird 2015-01-02 20:22:52

  • related to Bug #8331: Merge liveusb-creator upstream changes added

#8 Updated by BitingBird 2015-01-04 19:05:28

  • Affected tool set to Installer

#9 Updated by alant 2015-03-14 18:04:24

  • Subject changed from liveusb-creator should inhibit udisks to liveusb-creator prevent GNOME from managing the target device

I don’t think that inhibiting udisks is a solution, as it would prevent us from using it as far as I understood. The HintIgnore proprerty of org.freedesktop.UDisks2.Block (http://udisks.freedesktop.org/docs/latest/gdbus-org.freedesktop.UDisks2.Block.html#gdbus-property-org-freedesktop-UDisks2-Block.HintIgnore) looks like a good candidate, but it’s read-only.

#10 Updated by alant 2015-03-14 18:12:40

  • Subject changed from liveusb-creator prevent GNOME from managing the target device to liveusb-creator should prevent GNOME from managing the target device

#11 Updated by alant 2015-03-14 18:43:26

Adding the following /etc/udev/rules.d/99-hide-Tails.rules works but hides all partitions labeled Tails:

ENV{UDISKS_PARTITION_LABEL}=="Tails", ENV{UDISKS_IGNORE}="1"

#12 Updated by alant 2015-03-14 18:44:41

  • related to Feature #8290: Port Tails Installer to UDisks2 added

#13 Updated by intrigeri 2015-03-14 18:46:00

The misleading message appears every time since the port to UDisks v2 (while it only occasionally appeared on Wheezy / UDisks v1), so marking this as a subtask of Feature #8290 and assigning to Alan. Now, to evaluate this problem’s seriousness, we should check what happens when the user actually clicks on either of the buttons displayed by the notification: does it prevent the installation from completing successfully?

#14 Updated by intrigeri 2015-03-14 18:46:20

  • related to deleted (Feature #8290: Port Tails Installer to UDisks2)

#15 Updated by intrigeri 2015-03-14 18:46:38

  • Target version set to Tails_2.0
  • Parent task set to Feature #8290
  • Starter changed from Yes to No

#16 Updated by intrigeri 2015-03-15 09:16:55

  • Assignee set to alant

Alan, I guess you’ll take it as part of Feature #8290. If you can’t take care of this shortly, please let us know.

#17 Updated by intrigeri 2015-03-15 14:47:00

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 10

Actually, the problem happens because in partition_device, partition_table.call_create_partition_sync fails (and we ignore the error), and then the correct partition type (ESP) isn’t set: if it was, then 80-udisks2.rules would set UDISKS_IGNORE on the filesystem. I’ve added an automated test for checking the resulting partition type.

Alan is working on fixing that.

#18 Updated by alant 2015-03-15 16:05:03

  • % Done changed from 10 to 30

ESP are automatically ignored by UDisks, but liveusb-creator failed to set ESP GUID. This should be fixed by commit liveusb-creator:b2680d8 “Actually sets the ESP partition type”.

This should now be tested within a real Tails.

#19 Updated by intrigeri 2015-03-15 19:24:45

  • Status changed from In Progress to Resolved
  • Assignee deleted (alant)
  • % Done changed from 30 to 100

Works for me.

#20 Updated by intrigeri 2015-04-26 04:07:51

  • related to Feature #9280: Jessie: Ensure that the persistent volume is not managed by GNOME while it's being created added