Feature #5741

tails-greeter: always list optimal keyboard layout

Added by Tails 2013-07-18 07:45:30 . Updated 2020-04-15 06:05:22 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Target version:
Start date:
Due date:
% Done:

50%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
0
Affected tool:
Welcome Screen
Deliverable for:

Description

Tails Greeter fails to set the correct keyboard layout for some "Other…" type of languages. The following languages only get the USA layout, but localization otherwise seems correct (e.g. GNOME is translated):

  • Norsk bokmal (should get Nor (Norwegian))
  • Sardinian (should get Ita (Italian) perhaps?)
  • Hrvatski (should get Hrv (Croatian))
  • Portuguese/Brazil (should get Portuguese (Brazil), not Portuguese)

Subtasks

History

#1 Updated by intrigeri 2013-07-19 08:52:55

  • Category set to 165

#2 Updated by winterfairy 2013-11-02 13:18:07

Portuguese gets both Portuguese and Brazil keyboard layout. Currently Portuguese is the default, that may change to Brazil with my new patches [1]. But question is, do we want the default keyboard layout to change when one switch country, but keeps the language the same? The current behaviour I believe is to only switch when changing language.

I can confirm that norwegian does get USA keyboard layout only. That is a bit sad as we have norwegian translations. I may investigate it further.

[1] mailman.boum.org/pipermail/tails-dev/2013-November/004003.html

#3 Updated by intrigeri 2013-11-04 06:16:13

  • Status changed from Confirmed to Fix committed
  • QA Check set to Pass
  • Starter set to No

Fixed by tails-greeter 0.7.21 for Tails 0.22.

The remaining questions shall be discussed on tails-dev, and have a dedicated ticket if we feel there is something to fix.

#4 Updated by winterfairy 2013-11-04 07:35:35

  • Status changed from Fix committed to Confirmed
  • QA Check deleted (Pass)

My patches didn’t fix anything in this bug, I was just stating what behaviour I observed when testing. Basically that it was working for Portuguese already, before my patches.

Norwegian still have USA keyboard only, for example.

I may take the question to the mailing list if I feel there is anything to discuss.

#5 Updated by alant 2013-11-04 09:36:10

There is code that may fix that in `feature/localized_layout` (which depends on the wheezy branch). I didn’t take time to finish it and to test it yet unfortunately.

#6 Updated by winterfairy 2013-11-07 08:37:53

From all I can tell there is no code in “feature/localized_layouts” that isn’t in the “wheezy” branch, and the “wheezy” branch never merged that branch.

Am I missing it somehow, or am I looking in the wrong repository (greeter), or did you forgot to push it?

#7 Updated by winterfairy 2013-11-15 06:34:56

winterfairy wrote:
> But question is, do we want the default keyboard layout
> to change when one switch country, but keeps the
> language the same? The current behaviour I believe
> is to only switch when changing language.

I was wrong, it is currently switching when changing country too. So no question there.

#8 Updated by winterfairy 2013-11-15 12:21:34

  • Status changed from Confirmed to In Progress
  • Assignee set to intrigeri
  • QA Check set to Ready for QA

Fixed in my greeter repo (norwegian-layout branch):
https://mailman.boum.org/pipermail/tails-dev/2013-November/004157.html

But basically, the issues are that upstream (xklavier, xkb or x11) does
not support the languages, we were polling for them in the right way. My
fix only hacks around upstreams lack of support.

#9 Updated by intrigeri 2013-11-16 13:42:46

  • Assignee changed from intrigeri to winterfairy
  • % Done changed from 0 to 50
  • QA Check changed from Ready for QA to Info Needed

Reviewed, see tails-dev.

#11 Updated by winterfairy 2013-11-21 06:52:29

As we do not know what keyboard layout Sardinian really should have, this bug no longer covers fixing the Sardinian language. A Sardinian speaking user should report this information to us, or we will wait for upstream to fix it.

#12 Updated by winterfairy 2013-11-22 04:33:25

  • Assignee changed from winterfairy to intrigeri
  • QA Check changed from Info Needed to Ready for QA

Alright, here we go again:

Same branches in my greeter repo:
- bugfix/norwegian-layout
- bugfix/norwegian-layout-wheezy

Upstream status:
https://mailman.boum.org/pipermail/tails-dev/2013-November/004222.html

#13 Updated by intrigeri 2013-11-22 12:42:17

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)
  • QA Check deleted (Ready for QA)

Merged, pending for 0.22.

#14 Updated by intrigeri 2013-12-11 08:16:02

  • Status changed from Fix committed to Resolved

Fixed in 0.22.

#15 Updated by intrigeri 2020-04-15 06:05:22

  • Affected tool changed from Greeter to Welcome Screen