Bug #5465

test suite: fix persistence is not enabled check

Added by Tails 2013-07-18 07:41:29 . Updated 2014-03-19 07:36:56 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
Tails_0.23
Start date:
Due date:
% Done:

50%

Feature Branch:
test/fix-persistence-checks
Type of work:
Code
Blueprint:

Starter:
0
Affected tool:
Deliverable for:

Description

This check is incorrect:

data_part_dev = boot_device + "2"
assert(!@vm.execute("grep -q '^#{data_part_dev} ' /proc/mounts").success?,
       "Partition '#{data_part_dev}' from the boot device is mounted")

I believe it will success even if persistence is enabled.

Subtasks

Related issues

Blocked by Tails - Feature #6399: Finish the Rjb migration Resolved 2013-11-03

History

#1 Updated by intrigeri 2013-07-27 09:41:58

  • Assignee set to intrigeri
  • QA Check set to Ready for QA
  • Starter set to No

#2 Updated by intrigeri 2013-07-27 09:42:40

  • Feature Branch set to test/fix-persistence-checks

#3 Updated by intrigeri 2013-07-27 09:46:19

  • Tracker changed from Feature to Bug

#4 Updated by intrigeri 2013-07-27 10:00:09

  • Assignee changed from intrigeri to anonym
  • QA Check changed from Ready for QA to Dev Needed

First review emailed to tails-dev (“Please review’n’merge test/fix-persistence-checks” thread, July 27, 2013).

#5 Updated by intrigeri 2013-10-04 08:13:54

  • Category set to Test suite

#6 Updated by intrigeri 2013-12-26 15:46:12

#7 Updated by intrigeri 2013-12-27 10:55:48

  • Assignee changed from anonym to intrigeri
  • % Done changed from 0 to 50

I’ll bring this branch to a mergeable state.

#8 Updated by intrigeri 2013-12-27 12:15:41

I’ve implemented the robustness improvements I was asking for in July, and the feature passes.

Left to do: revert the split of the “all persistent directories are mounted” step out of “persistence is enabled”, to keep our features readable.

#9 Updated by intrigeri 2013-12-27 14:41:15

  • Assignee changed from intrigeri to bertagaz
  • QA Check changed from Dev Needed to Ready for QA

intrigeri wrote:
> Left to do: revert the split of the “all persistent directories are mounted” step out of “persistence is enabled”, to keep our features readable.

Done, the feature still passes for me. Ready to review’n’merge.

#10 Updated by intrigeri 2014-02-22 12:30:12

  • Target version set to Tails_0.23

#11 Updated by intrigeri 2014-02-22 12:31:59

  • Assignee changed from bertagaz to anonym

Reassigning to the current RM.

#12 Updated by intrigeri 2014-02-27 08:18:09

  • Status changed from Confirmed to In Progress

#13 Updated by anonym 2014-03-01 01:01:42

  • Status changed from In Progress to Fix committed
  • Assignee deleted (anonym)
  • QA Check changed from Ready for QA to Pass

Merged!

#14 Updated by anonym 2014-03-19 07:36:56

  • Status changed from Fix committed to Resolved