Tails

This step is actually a bit error prone. As this feature has to run on fast VM, this step often fails if the Tails VM has more memory than the default, as the VM takes long time to do the memory wiping on shutdown (perticulary in nested VM setup).

Indeed. Let’s bump the timeout into "5 minutes per GiB or RAM", like when we wait for the memory to be wiped in in erase_memory.feature. See commit 0867398.

This Shutdown Tails step seems to be used only in this feature and the memory wiping one. Maybe we could have 2 different ways to shutdown the machine, and in the case of this feature, simply use a @vm.destroy.

erase_memory.feature uses "I safely shutdown Tails" (which is a bad name) which doesn’t wait for the VM to shutdown (it depends on the next step to do that), like "I shutdown Tails" does. In that feature we instead wait for the wipe to finish so we can dump the memory. See commit 1889a6c which tries to make all this clearer.

In this feature we cannot use @vm.destroy since that can result in data loss from the USB drive (perhaps not for after installing or upgrading since the installer syncs, but certainly when read-write persistence is used).

Looks good to me, closing.