Bug #17708

Test suite: use popen_wait everywhere it's needed

Added by intrigeri 2020-05-12 14:45:25 . Updated 2020-05-12 14:45:25 .

Status:
Confirmed
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
Start date:
Due date:
% Done:

0%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

commit:643c6ac21e1b8501b32301840cf3f4e5b5771e47 introduced a helper that should be used “instead of IO.popen() when running a subprocess inside a try_for() or other Timeout::timeout() block”.

But it seems we may not be using this helper everywhere we should, e.g. Display#active? uses IO.popen(), and it is run in a try_for block by Display#start, so presumably it should be converted to popen_wait?

There may be other places where we should switch to popen_wait; I did not check.

Subtasks

History